From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Dave Jones <davej@redhat.com>, CAI Qian <caiqian@redhat.com>,
xfs@oss.sgi.com
Subject: Re: xfs_efi_item slab corruption. (v3.9-10936-g51a26ae)
Date: Fri, 10 May 2013 11:38:30 +1000 [thread overview]
Message-ID: <20130510013830.GO23072@dastard> (raw)
In-Reply-To: <518A5213.60307@sgi.com>
On Wed, May 08, 2013 at 08:24:35AM -0500, Mark Tinguely wrote:
> On 05/07/13 18:54, Dave Chinner wrote:
>
>
> Checking the EFI for whether it is being released from recovery
> after we've already released the known active reference is a mistake
> worthy of a brown paper bag. Fix the (now) obvious use after free
> that it can cause.
>
> Reported-by: Dave Jones <davej@redhat.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_extfree_item.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> Looks good.
>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Zach pointed out that the fix is much more complex than it needs to
be. I'll respin the patch and resend it later today.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-10 1:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:37 xfs_efi_item slab corruption. (v3.9-10936-g51a26ae) Dave Jones
2013-05-07 19:04 ` Mark Tinguely
2013-05-07 19:07 ` Dave Jones
2013-05-07 19:24 ` Mark Tinguely
2013-05-07 19:31 ` Dave Jones
2013-05-07 19:58 ` Mark Tinguely
2013-05-07 19:59 ` Dave Jones
2013-05-07 20:04 ` Mark Tinguely
2013-05-07 20:22 ` Dave Jones
2013-05-07 20:24 ` Mark Tinguely
2013-05-07 22:22 ` Dave Chinner
2013-05-07 22:45 ` Mark Tinguely
2013-05-07 23:54 ` Dave Chinner
2013-05-08 0:43 ` Dave Jones
2013-05-08 13:24 ` Mark Tinguely
2013-05-10 1:38 ` Dave Chinner [this message]
2013-05-11 12:09 ` Dmitry Monakhov
2013-05-12 0:40 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510013830.GO23072@dastard \
--to=david@fromorbit.com \
--cc=caiqian@redhat.com \
--cc=davej@redhat.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox