Re: [PATCH] xfstests: regression test for ext4 resize with non-extent files

Dave Chinner
2013-05-10T04:56:43Z

On Thu, May 09, 2013 at 10:05:56PM -0500, Eric Sandeen wrote:
> On 5/9/13 10:03 PM, Eryu Guan wrote:
> > On Fri, May 10, 2013 at 6:02 AM, Eric Sandeen <sandeen@redhat.com <mailto:sandeen@redhat.com>> wrote:
> >
>
> ...
>
> > index 53af708..4c3e2f4 100644
> > --- a/tests/ext4/group
> > +++ b/tests/ext4/group
> > @@ -9,3 +9,4 @@
> > 303 aio dangerous ioctl rw stress
> > 304 aio dangerous ioctl rw stress
> > 305 auto
> > +306 dangerous rw resize quick
> >
> >
> > I'm wondering why it's not in auto group :)
>
>
> because I forgot about auto! :)
>
> But it's also somewhat dangerous; it could oops or hang, so perhaps
> auto is not a good idea.

If the bug has already been fixed, then auto rather than dangerous
should be used. If the hang/panic cannot be fixed, or is going to
take some time to be fixed, that's when dangerous should be used.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com