From: Dave Chinner <david@fromorbit.com>
To: Tomas Racek <tracek@redhat.com>
Cc: lczerner@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: unify apostrophes in output files
Date: Mon, 13 May 2013 10:25:01 +1000 [thread overview]
Message-ID: <20130513002500.GI32675@dastard> (raw)
In-Reply-To: <1368349273-23968-2-git-send-email-tracek@redhat.com>
On Sun, May 12, 2013 at 11:01:13AM +0200, Tomas Racek wrote:
> With coreutils v8.16 the style of apostrophes changed from `word' to
> 'word'. This is breaking some tests which use the older form.
>
> This commit introduces function _filter_apostrophes and changes the
> affected tests.
I'm not sure this is the best approach as it means we have to
remember in future to do this filtering in the places that need it.
I suspect that we'd do better to filter the entire output file from
check before we diff the golden output and the test output. An
inplace sed modification would be all that is needed like:
# coreutils 2.20+ changed quote formats in error messages.
# filter the damage out so that golden images match both old
# and new versions of coreutils.
sed -i 's/`/'\''/g' <test output file>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-13 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 9:01 [PATCH 1/2] xfstests 200: remove words from output Tomas Racek
2013-05-12 9:01 ` [PATCH 2/2] xfstests: unify apostrophes in output files Tomas Racek
2013-05-13 0:25 ` Dave Chinner [this message]
2013-05-13 0:13 ` [PATCH 1/2] xfstests 200: remove words from output Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513002500.GI32675@dastard \
--to=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=tracek@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox