From: Dave Chinner <david@fromorbit.com>
To: Zheng Liu <gnehzuil.liu@gmail.com>
Cc: Rich Johnston <rjohnston@sgi.com>,
Zheng Liu <wenqing.lz@taobao.com>,
Eric Sandeen <sandeen@sandeen.net>,
xfs@oss.sgi.com
Subject: Re: [PATCH v4] xfstests: add a new test case for ext4 indirect-based file
Date: Mon, 13 May 2013 10:44:39 +1000 [thread overview]
Message-ID: <20130513004439.GJ32675@dastard> (raw)
In-Reply-To: <1368358464-11173-1-git-send-email-wenqing.lz@taobao.com>
On Sun, May 12, 2013 at 07:34:24PM +0800, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> After applied this commit (864688d3), xfstests #255 will not test a
> file system that cannot support fallocate(2), such as a indirect-based
> file in ext4. So we need to add a new generic test case to test it.
>
> The difference between #255 and this test case is only to use pwrite to
> allocate blocks. Other filesystems should survive in this test case.
> In the mean time, a new argument '-u' is added into _test_generic_punch
> not to run unwritten tests.
>
> Meanwhile this commit fixes a minor problem in #255 that testfile should
> use $seq.$$ as testfile.
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> Cc: Eric Sandeen <sandeen@sandeen.net>
> Cc: Dave Chinner <david@fromorbit.com>
> Cc: Rich Johnston <rjohnston@sgi.com>
This will need to be rebased on top of Eric's patch that removes the
need to pass -F to xfs_io for non-xfs filesystems....
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -114,3 +114,4 @@
> 309 auto quick
> 310 auto
> 311 auto metadata log
> +314 auto quick prealloc
Why would you add it to the prealloc group? The whole point of the
test is that it doesn't use prealloc, right?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-13 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 11:34 [PATCH v4] xfstests: add a new test case for ext4 indirect-based file Zheng Liu
2013-05-13 0:44 ` Dave Chinner [this message]
2013-05-13 9:32 ` Zheng Liu
2013-05-13 13:51 ` Eric Sandeen
2013-05-13 14:11 ` Zheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513004439.GJ32675@dastard \
--to=david@fromorbit.com \
--cc=gnehzuil.liu@gmail.com \
--cc=rjohnston@sgi.com \
--cc=sandeen@sandeen.net \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox