From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 309337F4C for ; Mon, 13 May 2013 08:54:02 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id EC315304067 for ; Mon, 13 May 2013 06:53:58 -0700 (PDT) Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by cuda.sgi.com with ESMTP id AezVInXufMUYvUjA (version=TLSv1 cipher=RC4-SHA bits=128 verify=NO) for ; Mon, 13 May 2013 06:53:57 -0700 (PDT) Received: by mail-pd0-f173.google.com with SMTP id v10so4455706pde.4 for ; Mon, 13 May 2013 06:53:57 -0700 (PDT) Date: Mon, 13 May 2013 22:11:42 +0800 From: Zheng Liu Subject: Re: [PATCH v4] xfstests: add a new test case for ext4 indirect-based file Message-ID: <20130513141142.GA13247@gmail.com> References: <1368358464-11173-1-git-send-email-wenqing.lz@taobao.com> <20130513004439.GJ32675@dastard> <20130513093245.GA8570@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: Rich Johnston , Zheng Liu , "xfs@oss.sgi.com" On Mon, May 13, 2013 at 08:51:20AM -0500, Eric Sandeen wrote: > On May 13, 2013, at 4:32 AM, Zheng Liu wrote: > > > On Mon, May 13, 2013 at 10:44:39AM +1000, Dave Chinner wrote: > >> On Sun, May 12, 2013 at 07:34:24PM +0800, Zheng Liu wrote: > >>> From: Zheng Liu > >>> > >>> After applied this commit (864688d3), xfstests #255 will not test a > >>> file system that cannot support fallocate(2), such as a indirect-based > >>> file in ext4. So we need to add a new generic test case to test it. > >>> > >>> The difference between #255 and this test case is only to use pwrite to > >>> allocate blocks. Other filesystems should survive in this test case. > >>> In the mean time, a new argument '-u' is added into _test_generic_punch > >>> not to run unwritten tests. > >>> > >>> Meanwhile this commit fixes a minor problem in #255 that testfile should > >>> use $seq.$$ as testfile. > >>> > >>> Signed-off-by: Zheng Liu > >>> Cc: Eric Sandeen > >>> Cc: Dave Chinner > >>> Cc: Rich Johnston > >> > >> This will need to be rebased on top of Eric's patch that removes the > >> need to pass -F to xfs_io for non-xfs filesystems.... > > > > Hi Dave, > > > > Thanks for review. I guess that you metioned this patch, right? > > [PATCH] xfstests: automatically add -F to xfs_io on non-xfs > > > > But I couldn't find it in xfstests tree. Has it been applied into the > > tree? Or maybe I use a wrong tree to generate my patch. I clone the > > tree from here: > > git://oss.sgi.com/xfs/cmds/xfstests > > > > Is that right? Or maybe I need to apply Eric's patch manually and > > rebase my patch? > > > That's the right patch, it's just not yet merged. You can just drop any "-F" from your xfs_io commands. Thanks for pointing it out. Fix it in next version. - Zheng _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs