From: Ben Myers <bpm@sgi.com>
To: Chris Friesen <chris.friesen@genband.com>
Cc: Alex Elder <elder@kernel.org>, xfs@oss.sgi.com
Subject: Re: any way to work backwards from xfs_inode_t to a filename?
Date: Wed, 15 May 2013 17:10:00 -0500 [thread overview]
Message-ID: <20130515221000.GX812@sgi.com> (raw)
In-Reply-To: <5194050B.7010401@genband.com>
Hey Chris,
On Wed, May 15, 2013 at 03:58:35PM -0600, Chris Friesen wrote:
> As I mentioned before I'm digging into some intermittent xfs
> corruption issues on an embedded system running a 2.6.27-based
> kernel.
>
> In one case I've hit XFS_WANT_CORRUPTED_GOTO in
> xfs_free_ag_extent(). In this particular case the call chain was
>
> xfs_free_ag_extent+0x55d/0x6e0
> xfs_free_extent+0xac/0xd0
> xfs_bmap_finish+0x156/0x1a0
> xfs_itruncate_finish+0x137/0x340
> xfs_inactive+0x386/0x4b0
> xfs_fs_clear_inode+0xc6/0x120
> clear_inode+0x58/0x110
> generic_delete_inode+0xff/0x110
> generic_drop_inode+0x16d/0x190
> iput+0x5d/0x70
> do_unlinkat+0x147/0x280
> sys_unlinkat+0x1d/0x40
>
> I have two questions:
>
> 1) do_unlinkat() has the filesystem path, but iput() returns void.
> Is there any way for me to add instrumentation to xfs_inactive() to
> work backwards from the xfs_inode_t pointer to print out a path to
> the file being deleted?
Use VFS_I to get to a 'struct inode' and from there you can look at the
dentries on i_dentry list and traverse back through the path by looking at
d_parent. Might be easier to just print the path in do_unlinkat?
> 2) If this sort of corruption happens again, what's my best bet for
> figuring out the source of the problem? This is an embedded system,
> so I need to be able to automate any data gathering (after which
> we'll run xfs_repair so we can return to service--any manual
> analysis will need to happen later based on stored data).
Can you grab a metadump before you repair the filesystem?
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-15 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 21:58 any way to work backwards from xfs_inode_t to a filename? Chris Friesen
2013-05-15 22:10 ` Ben Myers [this message]
2013-05-15 22:19 ` Eric Sandeen
2013-05-15 23:04 ` Ben Myers
2013-05-16 15:44 ` Chris Friesen
2013-05-15 22:20 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515221000.GX812@sgi.com \
--to=bpm@sgi.com \
--cc=chris.friesen@genband.com \
--cc=elder@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox