From: Dave Chinner <david@fromorbit.com>
To: Rich Johnston <rjohnston@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfstests: generic/235 breaks /etc/mtab symlinks breaks xfs/189
Date: Fri, 17 May 2013 08:41:14 +1000 [thread overview]
Message-ID: <20130516224114.GF24635@dastard> (raw)
In-Reply-To: <5194D12E.4000903@sgi.com>
On Thu, May 16, 2013 at 07:29:34AM -0500, Rich Johnston wrote:
> On 05/08/2013 08:21 PM, Dave Chinner wrote:
> >From: Dave Chinner <dchinner@redhat.com>
> >
> >Serenity lost.
> >Insanity looms darkly.
> >/etc/mtab
> >
> >Random behaviour.
> >xfs/189 fails
> >After a week passing.
> >
> >-SCRATCH_DEV on SCRATCH_MNT type xfs (ro,filestreams)
> >+SCRATCH_DEV on SCRATCH_MNT type xfs (ro,relatime,attr2,filestreams,inode64,noquota)
> >
> >Confusion prevails.
> >/proc/mounts can never give success.
> >Anything but golden.
> >
> >ls -l
> >/etc/mtab shows:
> >lrwxrwxrwx 1 root root 12 May 8 16:05 /etc/mtab -> /proc/mounts
> >
> >symlink modified.
> >Stealth. Deception. WTF?
> >Ninjas go unseen.
> >
> >"git grep mtab". Yay!
> >generic/235: sad
> >SElinux hack.
> >
> >Remount context grot.
> >Mount uses all options from
> >/etc/mtab
> >
> >Kernel rejects mount.
> >sed hacks /etc/mtab
> >Symlink becomes file.
> >
> >Test frobulation.
> >xfs/189 passes
> >Randomness tamed.
> >
> >Double face-palm. Tears.
> >Crack-inspired insanity.
> >mount(8) needs fixing.
> >
> >Schizophrenia.
> >/etc/mtab. Same thing.
> >Test psychiatry.
> >
> >Hack, slash, glue, polish.
> >xfs/189 fixed.
> >Made shiny again.
> >
> >Signed-off-by: Dave Chinner <dchinner@redhat.com>
> >---
>
> Thanks for the cleanup patches. Only comment is although I enjoy
> the humorous patch description, can we make it shorter?
No, I'm not going to rewrite it - there's nothing wrong with having
a long commit message to describe the change.
FWIW, the notes I wrote as I tracked down this problem are about
twice as long as this summary, so any straight up and down
description of the problem is not going to make the commit message
smaller. And a boring commit message will simply not convey the
insanity of the situation....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-16 22:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 1:21 [PATCH 0/3, V2] xfstests: more fixes Dave Chinner
2013-05-09 1:21 ` [PATCH 1/3] xfstests: fix incorrect redirect in generic/233 Dave Chinner
2013-05-09 1:21 ` [PATCH 2/3] xfstests: quota not supported on realtime filesystems Dave Chinner
2013-05-16 12:32 ` Rich Johnston
2013-05-16 12:34 ` Rich Johnston
2013-05-09 1:21 ` [PATCH 3/3] xfstests: generic/235 breaks /etc/mtab symlinks breaks xfs/189 Dave Chinner
2013-05-09 2:46 ` Michael L. Semon
2013-05-09 3:15 ` Dave Chinner
2013-05-16 12:29 ` Rich Johnston
2013-05-16 22:41 ` Dave Chinner [this message]
2013-05-17 11:53 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516224114.GF24635@dastard \
--to=david@fromorbit.com \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox