From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 08/11] xfs: don't emit v5 superblock warnings on write
Date: Wed, 22 May 2013 17:26:08 -0500 [thread overview]
Message-ID: <20130522222608.GR20028@sgi.com> (raw)
In-Reply-To: <1369123330-9579-9-git-send-email-david@fromorbit.com>
On Tue, May 21, 2013 at 06:02:07PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> We write the superblock every 30s or so which results in the
> verifier being called. Right now that results in this output
> every 30s:
>
> XFS (vda): Version 5 superblock detected. This kernel has EXPERIMENTAL support enabled!
> Use of these features in this kernel is at your own risk!
>
> And spamming the logs. Stop this output from occurring on superblock
> writes.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/xfs_mount.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index f6bfbd7..e8e310c 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -314,7 +314,8 @@ STATIC int
> xfs_mount_validate_sb(
> xfs_mount_t *mp,
> xfs_sb_t *sbp,
> - bool check_inprogress)
> + bool check_inprogress,
> + bool check_version)
> {
>
> /*
> @@ -337,9 +338,10 @@ xfs_mount_validate_sb(
>
> /*
> * Version 5 superblock feature mask validation. Reject combinations the
> - * kernel cannot support up front before checking anything else.
> + * kernel cannot support up front before checking anything else. For
> + * write validation, we don't need to check feature masks.
> */
> - if (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5) {
> + if (check_version && XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5) {
if (!quiet_version) {
> xfs_alert(mp,
> "Version 5 superblock detected. This kernel has EXPERIMENTAL support enabled!\n"
> "Use of these features in this kernel is at your own risk!");
}
Since the stated goal of the patch is to be quieter and not to disable useful
tests in the verifier, I suggest you disable the print rather than disable the
test.
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-22 22:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 8:01 [PATCH 00/11] xfs: fixes for 3.10-rc3 Dave Chinner
2013-05-21 8:02 ` [PATCH 01/11] xfs: avoid nesting transactions in xfs_qm_scall_setqlim() Dave Chinner
2013-05-21 18:35 ` Ben Myers
2013-05-21 8:02 ` [PATCH 02/11] xfs: remote attribute allocation may be contiguous Dave Chinner
2013-05-21 8:02 ` [PATCH 03/11] xfs: remote attribute read too short Dave Chinner
2013-05-21 20:59 ` Ben Myers
2013-05-21 22:53 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 04/11] xfs: remote attribute tail zeroing does too much Dave Chinner
2013-05-21 22:31 ` Ben Myers
2013-05-21 22:55 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 05/11] xfs: correctly map remote attr buffers during removal Dave Chinner
2013-05-22 17:01 ` Ben Myers
2013-05-21 8:02 ` [PATCH 06/11] xfs: fully initialise temp leaf in xfs_attr3_leaf_unbalance Dave Chinner
2013-05-22 20:50 ` Ben Myers
2013-05-22 23:54 ` Dave Chinner
2013-05-23 22:51 ` Ben Myers
2013-05-21 8:02 ` [PATCH 07/11] xfs: fully initialise temp leaf in xfs_attr3_leaf_compact Dave Chinner
2013-05-22 21:59 ` Ben Myers
2013-05-22 23:58 ` Dave Chinner
2013-05-23 22:51 ` Ben Myers
2013-05-21 8:02 ` [PATCH 08/11] xfs: don't emit v5 superblock warnings on write Dave Chinner
2013-05-22 22:26 ` Ben Myers [this message]
2013-05-23 0:03 ` Dave Chinner
2013-05-23 15:23 ` Ben Myers
2013-05-23 23:13 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 09/11] xfs: rework remote attr CRCs Dave Chinner
2013-05-23 21:54 ` Ben Myers
2013-05-23 23:35 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 10/11] xfs: fix incorrect remote symlink block count Dave Chinner
2013-05-24 20:36 ` Ben Myers
2013-05-24 20:39 ` Ben Myers
2013-05-24 23:41 ` Dave Chinner
2013-05-25 15:16 ` Ben Myers
2013-05-21 8:02 ` [PATCH 11/11] xfs: increase number of ACL entries for V5 superblocks Dave Chinner
2013-05-21 14:00 ` Brian Foster
2013-05-21 20:27 ` Dave Chinner
2013-05-21 16:26 ` [PATCH 00/11] xfs: fixes for 3.10-rc3 Ben Myers
2013-05-21 20:24 ` Dave Chinner
2013-05-21 20:52 ` Ben Myers
2013-05-21 21:27 ` Dave Chinner
2013-05-23 12:30 ` [PATCH 0/2] xfs: more " Dave Chinner
2013-05-23 12:30 ` [PATCH 1/2] xfs: rework dquot CRCs Dave Chinner
2013-05-23 12:30 ` [PATCH 2/2] xfs: fix split buffer vector log recovery support Dave Chinner
2013-05-24 8:58 ` [patch 0/2] xfs: yet more fixes for 3.10-rc3 Dave Chinner
2013-05-24 8:58 ` [PATCH 1/2] xfs: disable swap extents ioctl on CRC enabled filesystems Dave Chinner
2013-05-24 8:58 ` [PATCH 2/2] xfs: kill suid/sgid through the truncate path Dave Chinner
2013-05-24 10:02 ` Christoph Hellwig
2013-05-24 10:07 ` Christoph Hellwig
2013-05-24 18:29 ` [PATCH 00/11] xfs: fixes for 3.10-rc3 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522222608.GR20028@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox