From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 10/11] xfs: fix incorrect remote symlink block count
Date: Sat, 25 May 2013 09:41:44 +1000 [thread overview]
Message-ID: <20130524234144.GJ24543@dastard> (raw)
In-Reply-To: <20130524203910.GX20028@sgi.com>
On Fri, May 24, 2013 at 03:39:10PM -0500, Ben Myers wrote:
> On Fri, May 24, 2013 at 03:36:33PM -0500, Ben Myers wrote:
> > On Tue, May 21, 2013 at 06:02:09PM +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > When CRCs are enabled, the number of blocks needed to hold a remote
> > > symlink on a 1k block size filesystem may be 2 instead of 1. The
> > > transaction reservation for the allocated bloks was not taking this
> > blocks
> > > into account and only allocating one block. hence when trying to
> > H
> >
> > fixed.
> >
> > > read or invalidate such symlinks, we are mapping a hole where there
> > > should be a block and things go bad at that point.
> > >
> > > Fix the reservation to use the correct block count, clean up the
> > > block count calculation similar to the remote attribute calculation,
> > > and add a debug guard to detect when we don't write the entire
> > > symlink to disk.
> > >
> > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
...
> > > @@ -525,9 +518,7 @@ xfs_symlink(
> > > bp->b_ops = &xfs_symlink_buf_ops;
> > >
> > > byte_cnt = XFS_SYMLINK_BUF_SPACE(mp, byte_cnt);
> > > - if (pathlen < byte_cnt) {
> > > - byte_cnt = pathlen;
> > > - }
> > > + byte_cnt = min(byte_cnt, pathlen);
> >
> > The min is necessary due since we can have up to three extents in here,
> > according to the comment above the define for XFS_SYMLINK_MAPS. So byte_cnt
> > can be less than pathlen.
>
> D'oh. I wanted to point out that it looks like this issue with 'min' here
> should be causing problems with symlinks on non-crc enabled filesystems.
What issue might that be? The result is identical in either case, I
just converted this to min to be more concise and consistent with
the same code loops in the remote attr copyin/copyout.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-24 23:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 8:01 [PATCH 00/11] xfs: fixes for 3.10-rc3 Dave Chinner
2013-05-21 8:02 ` [PATCH 01/11] xfs: avoid nesting transactions in xfs_qm_scall_setqlim() Dave Chinner
2013-05-21 18:35 ` Ben Myers
2013-05-21 8:02 ` [PATCH 02/11] xfs: remote attribute allocation may be contiguous Dave Chinner
2013-05-21 8:02 ` [PATCH 03/11] xfs: remote attribute read too short Dave Chinner
2013-05-21 20:59 ` Ben Myers
2013-05-21 22:53 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 04/11] xfs: remote attribute tail zeroing does too much Dave Chinner
2013-05-21 22:31 ` Ben Myers
2013-05-21 22:55 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 05/11] xfs: correctly map remote attr buffers during removal Dave Chinner
2013-05-22 17:01 ` Ben Myers
2013-05-21 8:02 ` [PATCH 06/11] xfs: fully initialise temp leaf in xfs_attr3_leaf_unbalance Dave Chinner
2013-05-22 20:50 ` Ben Myers
2013-05-22 23:54 ` Dave Chinner
2013-05-23 22:51 ` Ben Myers
2013-05-21 8:02 ` [PATCH 07/11] xfs: fully initialise temp leaf in xfs_attr3_leaf_compact Dave Chinner
2013-05-22 21:59 ` Ben Myers
2013-05-22 23:58 ` Dave Chinner
2013-05-23 22:51 ` Ben Myers
2013-05-21 8:02 ` [PATCH 08/11] xfs: don't emit v5 superblock warnings on write Dave Chinner
2013-05-22 22:26 ` Ben Myers
2013-05-23 0:03 ` Dave Chinner
2013-05-23 15:23 ` Ben Myers
2013-05-23 23:13 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 09/11] xfs: rework remote attr CRCs Dave Chinner
2013-05-23 21:54 ` Ben Myers
2013-05-23 23:35 ` Dave Chinner
2013-05-21 8:02 ` [PATCH 10/11] xfs: fix incorrect remote symlink block count Dave Chinner
2013-05-24 20:36 ` Ben Myers
2013-05-24 20:39 ` Ben Myers
2013-05-24 23:41 ` Dave Chinner [this message]
2013-05-25 15:16 ` Ben Myers
2013-05-21 8:02 ` [PATCH 11/11] xfs: increase number of ACL entries for V5 superblocks Dave Chinner
2013-05-21 14:00 ` Brian Foster
2013-05-21 20:27 ` Dave Chinner
2013-05-21 16:26 ` [PATCH 00/11] xfs: fixes for 3.10-rc3 Ben Myers
2013-05-21 20:24 ` Dave Chinner
2013-05-21 20:52 ` Ben Myers
2013-05-21 21:27 ` Dave Chinner
2013-05-23 12:30 ` [PATCH 0/2] xfs: more " Dave Chinner
2013-05-23 12:30 ` [PATCH 1/2] xfs: rework dquot CRCs Dave Chinner
2013-05-23 12:30 ` [PATCH 2/2] xfs: fix split buffer vector log recovery support Dave Chinner
2013-05-24 8:58 ` [patch 0/2] xfs: yet more fixes for 3.10-rc3 Dave Chinner
2013-05-24 8:58 ` [PATCH 1/2] xfs: disable swap extents ioctl on CRC enabled filesystems Dave Chinner
2013-05-24 8:58 ` [PATCH 2/2] xfs: kill suid/sgid through the truncate path Dave Chinner
2013-05-24 10:02 ` Christoph Hellwig
2013-05-24 10:07 ` Christoph Hellwig
2013-05-24 18:29 ` [PATCH 00/11] xfs: fixes for 3.10-rc3 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524234144.GJ24543@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox