From: Dave Chinner <david@fromorbit.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: "Michael L. Semon" <mlsemon35@gmail.com>, xfs@oss.sgi.com
Subject: Re: xfsprogs: is it one issue?
Date: Mon, 27 May 2013 09:11:22 +1000 [thread overview]
Message-ID: <20130526231122.GO24543@dastard> (raw)
In-Reply-To: <CAEH94Lj4_8PBbhdD2f-ZFG=NxgS2uBkGUfaQvct71H4X7giPZA@mail.gmail.com>
On Sun, May 26, 2013 at 07:11:03AM +0800, Zhi Yong Wu wrote:
> I remove the lines related to h_chksum, then it can work well, so i
> guess that i should send out one patch to fix it.
While it will make the code in loggen work the same (it just writes
0 to the field but the buffer is already zeroed) as it does now,
it doesn't necessarily mean it works correctly. The current kernels
validate the CRC and throw warnings if the CRC isn't correct, and
CRC enabled kernels will simply refuse to mount.
As it is, my test systems don't build loggen because
HAVE_XLOG_ASSIGN_LSN isn't set by configure. It only gets set if
there's an xfs/libxfs.h header file found in an include path. My
guess is that you've run 'make install-qa' in the xfsprogs package
at some time in the past, and that's why loggen is trying to be
built.
So Michael's quick hack to remove it just to make it compile at this
point is probably appropriate...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-26 23:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 16:29 xfsprogs: is it one issue? Zhi Yong Wu
2013-05-25 19:43 ` Michael L. Semon
2013-05-25 22:57 ` Zhi Yong Wu
2013-05-25 23:11 ` Zhi Yong Wu
2013-05-26 23:11 ` Dave Chinner [this message]
2013-05-27 1:16 ` Zhi Yong Wu
2013-05-25 21:07 ` Eric Sandeen
2013-05-25 22:46 ` Zhi Yong Wu
2013-05-26 22:44 ` Dave Chinner
2013-05-26 22:48 ` Dave Chinner
2013-05-27 1:17 ` Zhi Yong Wu
2013-06-07 22:31 ` Arkadiusz Miśkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130526231122.GO24543@dastard \
--to=david@fromorbit.com \
--cc=mlsemon35@gmail.com \
--cc=xfs@oss.sgi.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox