public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/9] xfs: disable swap extents ioctl on CRC enabled filesystems
Date: Tue, 28 May 2013 16:49:31 -0500	[thread overview]
Message-ID: <20130528214931.GA20028@sgi.com> (raw)
In-Reply-To: <1369636707-15150-7-git-send-email-david@fromorbit.com>

On Mon, May 27, 2013 at 04:38:24PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Currently, swapping extents from one inode to another is a simple
> act of switching data and attribute forks from one inode to another.
> This, unfortunately in no longer so simple with CRC enabled
> filesystems as there is owner information embedded into the BMBT
> blocks that are swapped between inodes. Hence swapping the forks
> between inodes results in the inodes having mapping blocks that
> point to the wrong owner and hence are considered corrupt.
> 
> To fix this we need an extent tree block or record based swap
> algorithm so that the BMBT block owner information can be updated
> atomically in the swap transaction. This is a significant piece of
> new work, so for the moment simply don't allow swap extent
> operations to succeed on CRC enabled filesystems.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

I believe we do want to have functional swap extents for crc enabled
filesystems.  But this is fine as long as it is temporary.  Thanks Eric for
pointing this out on IRC.   Looks fine.

Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-05-28 21:49 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27  6:38 [PATH 0/9] xfs: fixes for 3.10-rc4 Dave Chinner
2013-05-27  6:38 ` [PATCH 1/9] xfs: don't emit v5 superblock warnings on write Dave Chinner
2013-05-29 16:39   ` Brian Foster
2013-05-30 17:49     ` Ben Myers
2013-06-11  6:05       ` Dave Chinner
2013-06-11 21:29         ` Ben Myers
2013-05-27  6:38 ` [PATCH 2/9] xfs: fix incorrect remote symlink block count Dave Chinner
2013-05-29 16:39   ` Brian Foster
2013-05-30  0:46     ` Dave Chinner
2013-05-30 17:49     ` Ben Myers
2013-05-27  6:38 ` [PATCH 3/9] xfs: increase number of ACL entries for V5 superblocks Dave Chinner
2013-05-29 16:40   ` Brian Foster
2013-05-27  6:38 ` [PATCH 4/9] xfs: rework dquot CRCs Dave Chinner
2013-05-29 18:58   ` Brian Foster
2013-05-30  1:00     ` Dave Chinner
2013-05-30 12:02       ` Brian Foster
2013-06-03  4:12         ` Dave Chinner
2013-05-27  6:38 ` [PATCH 5/9] xfs: fix split buffer vector log recovery support Dave Chinner
2013-05-29 19:21   ` Mark Tinguely
2013-05-30 17:49     ` Ben Myers
2013-05-27  6:38 ` [PATCH 6/9] xfs: disable swap extents ioctl on CRC enabled filesystems Dave Chinner
2013-05-28 21:49   ` Ben Myers [this message]
2013-05-30  1:07     ` Dave Chinner
2013-05-29 21:06   ` Brian Foster
2013-05-30 17:56     ` Ben Myers
2013-05-27  6:38 ` [PATCH 7/9] xfs: kill suid/sgid through the truncate path Dave Chinner
2013-05-30 14:17   ` Brian Foster
2013-05-30 15:52     ` Ben Myers
2013-05-30 16:02       ` Brian Foster
2013-05-30 17:07         ` Ben Myers
2013-05-27  6:38 ` [PATCH 8/9] xfs: add fsgeom flag for v5 superblock support Dave Chinner
2013-05-29 15:10   ` Eric Sandeen
2013-05-29 21:43     ` Ben Myers
2013-05-29 21:47       ` Ben Myers
2013-05-30  1:28       ` Dave Chinner
2013-05-30  1:11     ` Dave Chinner
2013-05-30 14:17   ` Brian Foster
2013-05-30 17:57     ` Ben Myers
2013-05-27  6:38 ` [PATCH 9/9] xfs: inode unlinked list needs to recalculate the inode CRC Dave Chinner
2013-05-28 11:51   ` Dave Chinner
2013-05-28 20:36   ` [PATCH 9a,9b v2, replacements] xfs: unlinked list crcs Dave Chinner
2013-05-28 20:36     ` [PATCH 1/2] xfs: fix log recovery transaction item reordering Dave Chinner
2013-05-28 20:36     ` [PATCH 2/2] xfs: inode unlinked list needs to recalculate the inode CRC Dave Chinner
2013-05-30 14:17       ` Brian Foster
2013-05-30 20:27         ` Dave Chinner
2013-05-28  8:37 ` [PATCH 10/9] xfs: fix dir3 freespace block corruption Dave Chinner
2013-05-30 19:15   ` Ben Myers
2013-05-31 21:54     ` Ben Myers
2013-05-28 17:56 ` [PATH 0/9] xfs: fixes for 3.10-rc4 Ben Myers
2013-05-28 23:54   ` Dave Chinner
2013-05-29 19:01     ` Ben Myers
2013-05-29 19:27       ` Eric Sandeen
2013-05-29 19:45         ` Ben Myers
2013-05-28 21:27 ` [PATCH 11/9] xfs: fix remote attribute invalidation for a leaf Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130528214931.GA20028@sgi.com \
    --to=bpm@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox