From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id E8BCE7F37 for ; Wed, 29 May 2013 20:07:38 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 82BF4AC003 for ; Wed, 29 May 2013 18:07:35 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id JokNwkeEUEf9iYEW for ; Wed, 29 May 2013 18:07:31 -0700 (PDT) Date: Thu, 30 May 2013 11:07:21 +1000 From: Dave Chinner Subject: Re: [PATCH 6/9] xfs: disable swap extents ioctl on CRC enabled filesystems Message-ID: <20130530010721.GG29466@dastard> References: <1369636707-15150-1-git-send-email-david@fromorbit.com> <1369636707-15150-7-git-send-email-david@fromorbit.com> <20130528214931.GA20028@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130528214931.GA20028@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ben Myers Cc: xfs@oss.sgi.com On Tue, May 28, 2013 at 04:49:31PM -0500, Ben Myers wrote: > On Mon, May 27, 2013 at 04:38:24PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > Currently, swapping extents from one inode to another is a simple > > act of switching data and attribute forks from one inode to another. > > This, unfortunately in no longer so simple with CRC enabled > > filesystems as there is owner information embedded into the BMBT > > blocks that are swapped between inodes. Hence swapping the forks > > between inodes results in the inodes having mapping blocks that > > point to the wrong owner and hence are considered corrupt. > > > > To fix this we need an extent tree block or record based swap > > algorithm so that the BMBT block owner information can be updated > > atomically in the swap transaction. This is a significant piece of > > new work, so for the moment simply don't allow swap extent > > operations to succeed on CRC enabled filesystems. > > > > Signed-off-by: Dave Chinner > > I believe we do want to have functional swap extents for crc enabled > filesystems. Of course. > But this is fine as long as it is temporary. It is. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs