From: Dave Chinner <david@fromorbit.com>
To: Rich Johnston <rjohnston@sgi.com>
Cc: xfstests <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: Fix test wildcard expansion.
Date: Fri, 31 May 2013 08:12:11 +1000 [thread overview]
Message-ID: <20130530221211.GP29466@dastard> (raw)
In-Reply-To: <51A7CC6B.3030607@sgi.com>
On Thu, May 30, 2013 at 05:02:19PM -0500, Rich Johnston wrote:
>
> Before commit 38d58591 "xfstests: fix typo in check",
> check xfs/[0-9]?? would execute all tests/xfs/[0-9]?? because:
>
> 'if grep "^$testname" $group_file >/dev/null'
> returns the contents of $group_file because $testname="".
>
> Therefore xfs/[0-9]?? was echoed to $tmp.list
>
> Fix the parsing in check to expand the regular expressions for test names.
I just fixed this locally myself:
- if grep "^$test_name" $group_file >/dev/null ; then
+ if egrep "^$test_name" $group_file >/dev/null ; then
Which just tells grep to treat the pattern as an extended regex....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-30 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 22:02 [PATCH] xfstests: Fix test wildcard expansion Rich Johnston
2013-05-30 22:12 ` Dave Chinner [this message]
2013-05-30 22:32 ` [PATCH V2] " Rich Johnston
2013-05-30 22:38 ` Dave Chinner
2013-05-31 12:10 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530221211.GP29466@dastard \
--to=david@fromorbit.com \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox