From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: alexander.tsvetkov@oracle.com, xfs@oss.sgi.com
Subject: Re: XFStest suite problem
Date: Fri, 31 May 2013 08:43:58 +1000 [thread overview]
Message-ID: <20130530224358.GT29466@dastard> (raw)
In-Reply-To: <51A75745.7090805@sandeen.net>
On Thu, May 30, 2013 at 08:42:29AM -0500, Eric Sandeen wrote:
> On 5/30/13 3:07 AM, alexander.tsvetkov@oracle.com wrote:
> > I think the following code of "check" script incorrectly builds this exclude list:
> >
> > "-X) xfile=$2; shift ;
> > for d in $SRC_GROUPS $FSTYP; do
> > [ -f $SRC_DIR/$d/$xfile ] || continue
> > for f in `cat $SRC_DIR/$d/$xfile`; do
> > echo $d/$f >> $tmp.xlist
>
> Well, it is perhaps unexpected, but:
>
> -X file exclude individual tests
>
> I think it's designed to actually exclude tests contained in that
> file, not test numbers. It's not very obvious. :(
Right, it's a file full of test numbers to expunged. Two things can
be done here:
1. improve the description
2. change the `cat $file` to `egrep ^$SUPPORTED_TESTS $file`
so that it requires files in the same format as group
files.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-05-30 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 8:07 XFStest suite problem alexander.tsvetkov
2013-05-30 13:42 ` Eric Sandeen
2013-05-30 22:43 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530224358.GT29466@dastard \
--to=david@fromorbit.com \
--cc=alexander.tsvetkov@oracle.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox