From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: bpm@sgi.com, xfs@oss.sgi.com
Subject: Re: [PATCH 5/6] xfs: disable noattr2/attr2 mount options for CRC enabled filesystems
Date: Wed, 5 Jun 2013 11:49:11 +1000 [thread overview]
Message-ID: <20130605014911.GI29338@dastard> (raw)
In-Reply-To: <51AD0CD6.80404@sgi.com>
On Mon, Jun 03, 2013 at 04:38:30PM -0500, Mark Tinguely wrote:
> On 06/03/13 00:28, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >attr2 format is always enabled for v5 superblock filesystems, so the
> >mount options to enable or disable it need to be cause mount errors.
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
> > Documentation/filesystems/xfs.txt | 3 +++
> > fs/xfs/xfs_super.c | 11 +++++++++++
> > 2 files changed, 14 insertions(+)
> >
> >diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
> >index 3e4b3dd..83577f0 100644
> >--- a/Documentation/filesystems/xfs.txt
> >+++ b/Documentation/filesystems/xfs.txt
> >@@ -33,6 +33,9 @@ When mounting an XFS filesystem, the following options are accepted.
> > removing extended attributes) the on-disk superblock feature
> > bit field will be updated to reflect this format being in use.
> >
> >+ CRC enabled filesystems always use the attr2 format, and so
> Filesystems using the version 5 superblock always use the attr2
> format, and so
> >+ will reject the noattr2 mount option if it is set.
> reject the noattr2 mount option if it is set.
> >+
I'm going to leave that as "CRC enabled" as the mkfs option that
turns on V5 superblocks is "-m crc=1". IOWs, users aren't going to
know that V5 superblocks == CRC enabled, so the docco reflects
that.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-05 1:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:28 [PATCH 0/6] xfs: fixes for 3.10-rc4 Dave Chinner
2013-06-03 5:28 ` [PATCH 1/6] xfs: rework dquot CRCs Dave Chinner
2013-06-03 18:18 ` Brian Foster
2013-06-04 21:46 ` Ben Myers
2013-06-04 22:07 ` Ben Myers
2013-06-03 5:28 ` [PATCH 2/6] xfs: fix log recovery transaction item reordering Dave Chinner
2013-06-03 5:28 ` [PATCH 3/6] xfs: inode unlinked list needs to recalculate the inode CRC Dave Chinner
2013-06-03 18:18 ` Brian Foster
2013-06-04 3:06 ` Dave Chinner
2013-06-03 5:28 ` [PATCH 4/6] xfs: fix remote attribute invalidation for a leaf Dave Chinner
2013-06-03 18:59 ` Brian Foster
2013-06-03 19:09 ` Mark Tinguely
2013-06-04 3:13 ` Dave Chinner
2013-06-04 22:28 ` Ben Myers
2013-06-03 5:28 ` [PATCH 5/6] xfs: disable noattr2/attr2 mount options for CRC enabled filesystems Dave Chinner
2013-06-03 19:02 ` Brian Foster
2013-06-03 21:38 ` Mark Tinguely
2013-06-05 1:49 ` Dave Chinner [this message]
2013-06-03 5:28 ` [PATCH 6/6] xfs: increase number of ACL entries for V5 superblocks Dave Chinner
2013-06-03 22:08 ` Mark Tinguely
2013-06-04 3:26 ` Dave Chinner
2013-06-05 1:58 ` Dave Chinner
2013-06-04 15:34 ` Ben Myers
2013-06-04 22:29 ` Dave Chinner
2013-06-04 22:32 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605014911.GI29338@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox