Re: [PATCH 5/6] xfs: disable noattr2/attr2 mount options for CRC enabled filesystems

Dave Chinner
2013-06-05T01:49:18Z

On Mon, Jun 03, 2013 at 04:38:30PM -0500, Mark Tinguely wrote:
> On 06/03/13 00:28, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >attr2 format is always enabled for v5 superblock filesystems, so the
> >mount options to enable or disable it need to be cause mount errors.
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
> > Documentation/filesystems/xfs.txt | 3 +++
> > fs/xfs/xfs_super.c | 11 +++++++++++
> > 2 files changed, 14 insertions(+)
> >
> >diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
> >index 3e4b3dd..83577f0 100644
> >--- a/Documentation/filesystems/xfs.txt
> >+++ b/Documentation/filesystems/xfs.txt
> >@@ -33,6 +33,9 @@ When mounting an XFS filesystem, the following options are accepted.
> > removing extended attributes) the on-disk superblock feature
> > bit field will be updated to reflect this format being in use.
> >
> >+ CRC enabled filesystems always use the attr2 format, and so
> Filesystems using the version 5 superblock always use the attr2
> format, and so
> >+ will reject the noattr2 mount option if it is set.
> reject the noattr2 mount option if it is set.
> >+

I'm going to leave that as "CRC enabled" as the mkfs option that
turns on V5 superblocks is "-m crc=1". IOWs, users aren't going to
know that V5 superblocks == CRC enabled, so the docco reflects
that.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com