From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/1] xfs: xfs_inactive fails to cleanup symlinks with attributes
Date: Fri, 7 Jun 2013 07:51:49 +1000 [thread overview]
Message-ID: <20130606215149.GC29338@dastard> (raw)
In-Reply-To: <51B0FF1D.60402@sgi.com>
On Thu, Jun 06, 2013 at 04:29:01PM -0500, Mark Tinguely wrote:
> On 06/06/13 16:13, Dave Chinner wrote:
> >On Thu, Jun 06, 2013 at 02:17:15PM -0500, Mark Tinguely wrote:
> >>On 06/06/13 11:10, Mark Tinguely wrote:
> >>>Found this bug testing extended attributes.
> >>>
> >>># make a big symbolic link that is in the inode core and mostly fills it.
> >>># CRC enabled filesystem will use a 68 byte smaller link in the test.
> >>>
> >>>ln -s 1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/1234567890/0123456/a a
> >>>
> >>># the extended attribute will bump the symbolic link to a remote extent
> >>># I think only one of these attribute is needed, but they are so fun...
> >>>attr -Rs 1234567890ad a< /dev/null
> >>>attr -Rs 1234567890ae a< /dev/null
> >>>attr -Rs 1234567890af a< /dev/null
> >>>
> >>
> >>oops. the following steps are also needed - I took them out because I
> >>thought they were unecessary:
> >>
> >># remove the attributes:
> >>attr -Rr 1234567890ad a
> >>attr -Rr 1234567890ae a
> >>attr -Rr 1234567890af a
> >>
> >>now we will assert
> >
> >I cannot reproduce this on a current TOT kernel with or without
> >CRCs:
> >
> ># mkfs.xfs -f /dev/vdb
> >meta-data=/dev/vdb isize=256 agcount=4, agsize=720896 blks
.....
>
> Yes, these instructions are for a *256* byte inode with top of tree code.
Yup, that's what I was testing with. It's right there in the mkfs
output I posted. Hence I want your exact test script that reproduces
it, in case there's still something missing from what you've sent as
the test case....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-06-06 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 16:10 [PATCH 0/1] xfs: xfs_inactive fails to cleanup symlinks with attributes Mark Tinguely
2013-06-06 16:10 ` [PATCH 1/1] xfs: fix the symbolic link assert in xfs_ifree Mark Tinguely
2013-06-07 1:06 ` Dave Chinner
2013-06-07 14:05 ` Mark Tinguely
2013-06-06 19:17 ` [PATCH 0/1] xfs: xfs_inactive fails to cleanup symlinks with attributes Mark Tinguely
2013-06-06 21:13 ` Dave Chinner
2013-06-06 21:29 ` Mark Tinguely
2013-06-06 21:44 ` Eric Sandeen
2013-06-06 21:51 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606215149.GC29338@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox