Re: [PATCH 7/9] xfs: kill suid/sgid through the truncate path.

Ben Myers
2013-05-30T15:52:11Z

Hey Brian,

On Thu, May 30, 2013 at 10:17:30AM -0400, Brian Foster wrote:
> On 05/27/2013 02:38 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > XFS has failed to kill suid/sgid bits correctly when truncating
> > files of non-zero size since commit c4ed4243 ("xfs: split
> > xfs_setattr") introduced in the 3.1 kernel. Fix it.
> >
>
> The code makes sense and I can easily hit an assert when truncating
> (extending) a suid file on a debug kernel without this patch (and I see
> the suid dropped with the patch).

What commands did you use? It seems like this is dealing with S_ISGID, correct?

Thanks,
Ben