From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id E10B329DF8 for ; Tue, 11 Jun 2013 16:29:16 -0500 (CDT) Date: Tue, 11 Jun 2013 16:29:12 -0500 From: Ben Myers Subject: Re: [PATCH 1/9] xfs: don't emit v5 superblock warnings on write Message-ID: <20130611212912.GU20932@sgi.com> References: <1369636707-15150-1-git-send-email-david@fromorbit.com> <1369636707-15150-2-git-send-email-david@fromorbit.com> <51A62F2F.6040807@redhat.com> <20130530174915.GB20932@sgi.com> <20130611060546.GK29376@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130611060546.GK29376@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Brian Foster , xfs@oss.sgi.com Hi Dave, On Tue, Jun 11, 2013 at 04:05:46PM +1000, Dave Chinner wrote: > On Thu, May 30, 2013 at 12:49:15PM -0500, Ben Myers wrote: > > On Wed, May 29, 2013 at 12:39:11PM -0400, Brian Foster wrote: > > > On 05/27/2013 02:38 AM, Dave Chinner wrote: > > > > From: Dave Chinner > > > > > > > > We write the superblock every 30s or so which results in the > > > > verifier being called. Right now that results in this output > > > > every 30s: > > > > > > > > XFS (vda): Version 5 superblock detected. This kernel has EXPERIMENTAL support enabled! > > > > Use of these features in this kernel is at your own risk! > > > > > > > > And spamming the logs. > > > > > > > > We don't need to check for whether we support v5 superblocks or > > > > whether there are feature bits we don't support set as these are > > > > only relevant when we first mount the filesytem. i.e. on superblock > > > > read. Hence for the write verification we can just skip all the > > > > checks (and hence verbose output) altogether. > > > > > > > > Signed-off-by: Dave Chinner > > > > --- > > > > > > Reviewed-by: Brian Foster > > > > Applied. > > Ben, while I see this in the xfsdev tree, I don't see it in Linus' > tree. Did it get missed on the recent merges? If so, can you queue > it up for 3.10-rc6? Argh. I missed it in the shuffle. I'll queue it up for 3.10-rc6. Apologies, and a nice catch. -Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs