Re: [PATCH 15/27] xfs: reshuffle dir2 definitions around for userspace

Christoph Hellwig
2013-06-17T16:05:20Z

On Wed, Jun 12, 2013 at 08:22:35PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Many of the definitions within xfs_dir2_priv.h are needed in
> userspace outside libxfs. Definitions within xfs_dir2_priv.h are
> wholly contained within libxfs, so we need to shuffle some of the
> definitions around to keep consistency across files shared between
> user and kernel space.

I created the xfs_dir2_format.h header so that it would be self
contained. Despite not mentioning it in the description this patch
also moves typedefs out of xfs_dir2_format.h which is something I'd
rather avoid. Where in userspace would we need these defintions but
can't include xfs_dir2_format.h?