From: Dave Jones <davej@redhat.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: don't shutdown log recovery on validation errors
Date: Fri, 14 Jun 2013 12:17:24 -0400 [thread overview]
Message-ID: <20130614161724.GA11235@redhat.com> (raw)
In-Reply-To: <20130614160940.GA32736@sgi.com>
On Fri, Jun 14, 2013 at 11:09:40AM -0500, Ben Myers wrote:
> > > I think your suggestion that non-debug systems could warn instead of
> > > fail is a good one, but removing the verifier altogether is
> > > inappropriate.
> >
> > Changing every single verifier in a non-trivial way is not something
> > I'm about to do for a -rc6 kernel. Removing the verifiers from log
> > recovery just reverts to the pre-3.8 situation, so is perfectly
> > acceptable short term solution while we do the more invasive verify
> > changes.
> >
> > > Can you make the metadump available? I need to understand this better
> > > before I can sign off. Also: Any idea how far back this one goes?
> >
> > No, I can't make the metadump available to you - it was provided
> > privately and not obfuscated and so you'd have to ask Dave for it.
>
> Dave (Jones), could you make the metadump available to me? I'd like to
> understand this a little bit better. I'm a bit uncomfortable with the
> proposition that we should corrupt silently in this case...
Sorry, I don't have it any more. I'll see if I can recreate the problem
next week and prepare another dump.
Dave
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-14 16:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 2:19 [PATCH 0/3] xfs: fixes for 3.10-rc6 Dave Chinner
2013-06-12 2:19 ` [PATCH 1/3] xfs: don't shutdown log recovery on validation errors Dave Chinner
2013-06-13 1:04 ` Ben Myers
2013-06-13 2:08 ` Dave Chinner
2013-06-13 22:09 ` Ben Myers
2013-06-14 0:13 ` Dave Chinner
2013-06-14 12:55 ` Mark Tinguely
2013-06-14 16:09 ` Ben Myers
2013-06-14 16:15 ` Eric Sandeen
2013-06-14 19:08 ` Ben Myers
2013-06-14 19:18 ` Eric Sandeen
2013-06-14 19:44 ` Ben Myers
2013-06-14 19:54 ` Eric Sandeen
2013-06-14 20:22 ` Ben Myers
2013-06-28 18:54 ` Dave Jones
2013-06-28 19:24 ` Ben Myers
2013-06-28 19:28 ` Dave Jones
2013-06-28 19:31 ` Ben Myers
2013-06-15 0:56 ` Dave Chinner
2013-06-17 14:53 ` Ben Myers
2013-06-18 1:22 ` Dave Chinner
2013-06-14 16:17 ` Dave Jones [this message]
2013-06-14 16:31 ` Ben Myers
2013-06-12 2:19 ` [PATCH 2/3] xfs: fix implicit padding in directory and attr CRC formats Dave Chinner
2013-06-13 0:58 ` Ben Myers
2013-06-13 1:40 ` Michael L. Semon
2013-06-13 2:27 ` Dave Chinner
2013-06-13 21:31 ` Ben Myers
2013-06-12 2:19 ` [PATCH 3/3] xfs: ensure btree root split sets blkno correctly Dave Chinner
2013-06-13 19:16 ` Ben Myers
2013-06-14 0:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614161724.GA11235@redhat.com \
--to=davej@redhat.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox