From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Carlos Maiolino <cmaiolino@redhat.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix sgid inheritance for subdirectories inheriting default acls
Date: Mon, 17 Jun 2013 22:57:09 -0700 [thread overview]
Message-ID: <20130618055709.GA11600@infradead.org> (raw)
In-Reply-To: <20130618055351.GR29338@dastard>
On Tue, Jun 18, 2013 at 03:53:51PM +1000, Dave Chinner wrote:
> > I'd rather opencode updating the mode here, it's really just a tiny bit
> > of boilerplate code.
>
> Needs a transaction, though. Right now, there's no transaction code
> at all in xfs_acl.c and I'd kind of like to keep it that way as it's
> just a translation layer....
True. Maybe as a quick hack just extend the meaning of XFS_ATTR_NOACL
to also not do the checks? It's already the magic flag to mean that
we are called from the ACL code.
Alternatively move all of xfs_set_mode, or at least everything around
the "if (mode != inode->i_mode) " to xfs_iops.c.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-18 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 19:41 [PATCH] xfs: fix sgid inheritance for subdirectories inheriting default acls Carlos Maiolino
2013-06-17 12:16 ` Brian Foster
2013-06-18 4:49 ` Dave Chinner
2013-06-18 4:55 ` Christoph Hellwig
2013-06-18 5:53 ` Dave Chinner
2013-06-18 5:57 ` Christoph Hellwig [this message]
2013-06-18 6:21 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618055709.GA11600@infradead.org \
--to=hch@infradead.org \
--cc=cmaiolino@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox