From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4] xfs: fix the symbolic link assert in xfs_ifree
Date: Wed, 19 Jun 2013 07:38:10 +1000 [thread overview]
Message-ID: <20130618213810.GY29338@dastard> (raw)
In-Reply-To: <20130617203503.472644581@sgi.com>
On Mon, Jun 17, 2013 at 03:35:57PM -0500, Mark Tinguely wrote:
> a
> Content-Disposition: inline; filename=v4-xfs-fix-assert-in-xfs_ifree.patch
>
> Adding an extended attribute to a symbolic link can force that
> link to an remote extent. xfs_inactive() incorrectly assumes
> that any symbolic link small enough to be in the inode core
> is incore, resulting in the remote extent to not be removed.
> xfs_ifree() will assert on presence of this leaked remote extent.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
One minor, minor thing:
> + if (pathlen < 0 || pathlen > MAXPATHLEN) {
> + xfs_alert(mp, "%s: inode (%llx) bad symlink length (%d)",
(0x%llx)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-06-18 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 20:35 [PATCH v4] xfs: fix the symbolic link assert in xfs_ifree Mark Tinguely
2013-06-18 18:59 ` Ben Myers
2013-06-18 21:38 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618213810.GY29338@dastard \
--to=david@fromorbit.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox