From: Ben Myers <bpm@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: Mark Tinguely <tinguely@sgi.com>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v3 1/2] xfs: Remove XFS_MOUNT_RETERR
Date: Wed, 19 Jun 2013 14:55:06 -0500 [thread overview]
Message-ID: <20130619195506.GS20932@sgi.com> (raw)
In-Reply-To: <51824DB3.9050904@oracle.com>
On Thu, May 02, 2013 at 07:27:47PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> XFS_MOUNT_RETERR is going to be set at xfs_parseargs() if
> mp->m_dalign is enabled, so any time we enter "if (mp->m_dalign)"
> branch in xfs_update_alignment(), XFS_MOUNT_RETERR is set and so
> we always be emitting a warning and returning an error.
>
> Hence, we can remove it and get rid of a couple of redundant
> check up against it at xfs_upate_alignment().
>
> Thanks Dave Chinner for the suggestions of simplify the code
> in xfs_parseargs().
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> Cc: Dave Chinner <dchinner@redhat.com>
> Cc: Mark Tinguely <tinguely@sgi.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-06-19 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 11:27 [PATCH v3 1/2] xfs: Remove XFS_MOUNT_RETERR Jeff Liu
2013-05-02 15:27 ` Mark Tinguely
2013-05-02 15:34 ` Jeff Liu
2013-06-19 19:55 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619195506.GS20932@sgi.com \
--to=bpm@sgi.com \
--cc=jeff.liu@oracle.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox