From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Ric Wheeler <rwheeler@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 00/60] xfs: patch queue for 3.11
Date: Thu, 20 Jun 2013 14:14:33 -0500 [thread overview]
Message-ID: <20130620191433.GY32736@sgi.com> (raw)
In-Reply-To: <20130619233347.GK29338@dastard>
Hey Dave,
On Thu, Jun 20, 2013 at 09:33:47AM +1000, Dave Chinner wrote:
> On Wed, Jun 19, 2013 at 10:47:09AM -0500, Ben Myers wrote:
> > On Wed, Jun 19, 2013 at 10:54:26AM -0400, Ric Wheeler wrote:
> > > On 06/19/2013 10:44 AM, Christoph Hellwig wrote:
> > > >On Wed, Jun 19, 2013 at 09:35:37AM -0500, Ben Myers wrote:
> > > >>>On Wed, Jun 19, 2013 at 02:50:08PM +1000, Dave Chinner wrote:
> > > >>>> >This is my patch queue for 3.11 as it stands right now.
> > > >>>
> > > >>>Getting all of this in for 3.11 does not strike me as being realistic. You
> > > >>>need to think about how this can be split up. I see that you have rebased
> > > >>>Jeff's log size validation patch set after your rearrangement. I'd rather
> > > >>>you'd taken Jeff's series first and then made your changes. Now we can't pull
> > > >>>in Jeff's work without pulling in a bunch of rearrangement that hasn't been
> > > >>>fully discussed. You have also crowded out Chandra's quota work. We had an
> > > >>>agreement with him to go for 3.11 with that work which you have broken.
> > >
> > > >I think 3.11 is a realistic target for all the code movearound, but
> > > >maybe not as part of the normal pull request for -rc1. If we make sure
> > > >it's really moving code around and not changing it I think a sending a
> > > >second pull request to Linus saying this is just code movearounds we
> > > >wanted to do when the churn causes least problems with actual code work
> > > >he should be fine with it.
> > >
> > > Just to chime in here, we have a lot of resources focused on testing
> > > these XFS updates both internally with our QA team and with a range
> > > of other RH partners.
> >
> > This isn't about the size of your QA team or the number of other RH partners.
> >
> > We had an agreement with Chandra to work toward getting his quota work in 3.11
> > and it appears that Dave has crowded him out with a rearrangement of code which
> > we had no agreement would go into 3.11.
>
> What I posted is what I'm *proposing* for 3.11. You can't have an
> agreement with first having a proposal....
>
> > Further, Dave has taken Jeff's log
> > size validation series hostage by rebasing it on top of this rearrangement of
> > code.
>
> Ben, I think you're being a little melodramatic here. I asked Jeff
> if it was OK to rebase his patchset, and he said that was fine:
>
> http://oss.sgi.com/pipermail/xfs/2013-June/027270.html
>
> You don't have to take my rebase of Jeff's patches - you're welcome
> to take them direct from Jeff, but then I'll have to send reviews
> asking for changes to problems I found when integrating it so that's
> going to delay any integration you can do of that series. Please let
> Jeff and myself know what you want to do here...
>
> > If there is a strategic reason that RH needs to have the kernel/libxfs code
> > rearranged and separated in 3.11 I would have liked to have heard about it
> > before now. I'm all for getting this work done, but not at the expense of
> > crowding out other XFS contributors.
>
> You are making a mountain out of a molehill. I had an itch, and I
> scratched it. Simple as that. It is only a couple of days work.
You jumped the queue in front of the other cars. I'm asking you not to do
that, even if one of the drivers was kind enough to let you in.
> If you think it's too much for 3.11, then just say so and leave it at that.
> I'll move it to my for-3.12 queue and you won't see it again until after
> 3.11-rc1 is released...
Lets see where Chandra is at with his quota work. If he has already rebased on
top of your series I don't see a good reason to rearrange things now. If he
hasn't, I'd like focus on getting his code merged before pulling in your
rearrangement. Now that you've rebased Jeff's work, I don't see much point in
redoing that, so maybe that will have to wait for the rearrangement to get
merged.
For now we'll focus on the first 13 patches.
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-20 19:14 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 4:50 [PATCH 00/60] xfs: patch queue for 3.11 Dave Chinner
2013-06-19 4:50 ` [PATCH 01/60] xfs: update mount options documentation Dave Chinner
2013-06-20 15:35 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 02/60] xfs: add pluging for bulkstat readahead Dave Chinner
2013-06-20 16:59 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 03/60] xfs: plug directory buffer readahead Dave Chinner
2013-06-20 18:45 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 04/60] xfs: don't use speculative prealloc for small files Dave Chinner
2013-06-19 12:59 ` Brian Foster
2013-06-20 19:31 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 05/60] xfs: don't do IO when creating an new inode Dave Chinner
2013-06-21 13:57 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer Dave Chinner
2013-06-21 21:24 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 07/60] xfs: Introduce ordered log vector support Dave Chinner
2013-06-22 17:26 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 08/60] xfs: Introduce an ordered buffer item Dave Chinner
2013-06-23 17:27 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 09/60] xfs: Inode create log items Dave Chinner
2013-06-22 15:49 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 10/60] xfs: Inode create transaction reservations Dave Chinner
2013-06-23 17:29 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 11/60] xfs: Inode create item recovery Dave Chinner
2013-06-24 14:37 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 12/60] xfs: Use inode create transaction Dave Chinner
2013-06-24 18:55 ` Mark Tinguely
2013-06-19 4:50 ` [PATCH 13/60] xfs: remove local fork format handling from xfs_bmapi_write() Dave Chinner
2013-06-19 4:50 ` [PATCH 14/60] xfs: move getdents code into it's own file Dave Chinner
2013-06-19 4:50 ` [PATCH 15/60] xfs: reshuffle dir2 definitions around for userspace Dave Chinner
2013-06-19 4:50 ` [PATCH 16/60] xfs: split out attribute listing code into separate file Dave Chinner
2013-06-19 4:50 ` [PATCH 17/60] xfs: split out attribute fork truncation " Dave Chinner
2013-06-19 4:50 ` [PATCH 18/60] xfs: split out xfs inode operations " Dave Chinner
2013-06-19 4:50 ` [PATCH 19/60] xfs: consolidate xfs_vnodeops.c into xfs_inode_ops.c Dave Chinner
2013-06-19 4:50 ` [PATCH 20/60] xfs: move xfs_getbmap to xfs_extent_ops.c Dave Chinner
2013-06-19 4:50 ` [PATCH 21/60] xfs: introduce xfs_sb.c for sharing with libxfs Dave Chinner
2013-06-19 4:50 ` [PATCH 22/60] xfs: move xfs_trans_reservations to xfs_trans.h Dave Chinner
2013-06-19 4:50 ` [PATCH 23/60] xfs: sync minor header differences needed by userspace Dave Chinner
2013-06-19 4:50 ` [PATCH 24/60] xfs: move xfs_bmap_punch_delalloc() to xfs_aops.c Dave Chinner
2013-06-19 4:50 ` [PATCH 25/60] xfs: split out transaction reservation code Dave Chinner
2013-06-19 4:50 ` [PATCH 26/60] xfs: minor cleanups Dave Chinner
2013-06-19 4:50 ` [PATCH 27/60] xfs: fix issues that cause userspace warnings Dave Chinner
2013-06-19 4:50 ` [PATCH 28/60] xfs: consolidate xfs_rename.c Dave Chinner
2013-06-19 4:50 ` [PATCH 29/60] xfs: consolidate xfs_utils.c Dave Chinner
2013-06-19 9:40 ` Christoph Hellwig
2013-06-19 4:50 ` [PATCH 30/60] xfs: split out inode log item format definition Dave Chinner
2013-06-19 4:50 ` [PATCH 31/60] xfs: split out buf log item format definitions Dave Chinner
2013-06-19 4:50 ` [PATCH 32/60] xfs: move inode fork definitions to a new header file Dave Chinner
2013-06-19 4:50 ` [PATCH 33/60] xfs: move unrealted definitions out of xfs_inode.h Dave Chinner
2013-06-19 4:50 ` [PATCH 34/60] xfs: introduce xfs_inode_buf.c for inode buffer operations Dave Chinner
2013-06-19 4:50 ` [PATCH 35/60] xfs: start repopulating xfs_inode.[ch] with kernel code Dave Chinner
2013-06-19 4:50 ` [PATCH 36/60] xfs: move swap extent code to xfs_extent_ops Dave Chinner
2013-06-19 4:50 ` [PATCH 37/60] xfs: split out inode log item format definition Dave Chinner
2013-06-19 4:50 ` [PATCH 38/60] xfs: separate dquot on disk format definitions out of xfs_quota.h Dave Chinner
2013-06-19 4:50 ` [PATCH 39/60] xfs: separate icreate log format definitions from xfs_icreate_item.h Dave Chinner
2013-06-19 4:50 ` [PATCH 40/60] xfs: don't special case shared superblock mounts Dave Chinner
2013-06-19 4:50 ` [PATCH 41/60] xfs: kill __KERNEL__ check for debug code in allocation code Dave Chinner
2013-06-19 4:50 ` [PATCH 42/60] xfs: split out on-disk transaction definitions Dave Chinner
2013-06-19 4:50 ` [PATCH 43/60] xfs: remove __KERNEL__ from debug code Dave Chinner
2013-06-19 4:50 ` [PATCH 44/60] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c Dave Chinner
2013-06-19 4:50 ` [PATCH 45/60] xfs: xfs_filestreams.h doesn't need __KERNEL__ Dave Chinner
2013-06-19 4:50 ` [PATCH 46/60] xfs: split out the remote symlink handling Dave Chinner
2013-06-19 4:50 ` [PATCH 47/60] xfs: separate out log format definitions Dave Chinner
2013-06-19 4:50 ` [PATCH 48/60] xfs: move kernel specific type definitions to xfs.h Dave Chinner
2013-06-19 4:50 ` [PATCH 49/60] xfs: make struct xfs_perag kernel only Dave Chinner
2013-06-19 4:50 ` [PATCH 50/60] xfs: create xfs_bmap_util.[ch] Dave Chinner
2013-06-19 4:50 ` [PATCH 51/60] xfs: introduce xfs_quota_defs.h Dave Chinner
2013-06-19 4:51 ` [PATCH 52/60] xfs: introduce xfs_rtalloc_defs.h Dave Chinner
2013-06-19 4:51 ` [PATCH 53/60] xfs: Introduce a new structure to hold transaction reservation items Dave Chinner
2013-06-19 4:51 ` [PATCH 54/60] xfs: Introduce tr_fsyncts to m_reservation Dave Chinner
2013-06-19 4:51 ` [PATCH 55/60] xfs: Make writeid transaction use tr_writeid Dave Chinner
2013-06-19 4:51 ` [PATCH 56/60] xfs: refactor xfs_trans_reserve() interface Dave Chinner
2013-06-19 4:51 ` [PATCH 57/60] xfs: Get rid of all XFS_XXX_LOG_RES() macro Dave Chinner
2013-06-19 4:51 ` [PATCH 58/60] xfs: Refactor xfs_ticket_alloc() to extract a new helper Dave Chinner
2013-06-19 4:51 ` [PATCH 59/60] xfs: Add xfs_log_rlimit.c Dave Chinner
2013-06-20 17:24 ` Michael L. Semon
2013-06-21 6:10 ` Michael L. Semon
2013-06-24 21:26 ` Mark Tinguely
2013-06-24 22:27 ` Dave Chinner
2013-06-25 14:06 ` Mark Tinguely
2013-06-26 4:05 ` Dave Chinner
2013-06-26 13:48 ` Mark Tinguely
2013-06-26 22:18 ` Dave Chinner
2013-06-19 4:51 ` [PATCH 60/60] xfs: Validate log space at mount time Dave Chinner
2013-06-19 9:15 ` [PATCH 00/60] xfs: patch queue for 3.11 Christoph Hellwig
2013-06-19 21:34 ` Dave Chinner
2013-06-20 9:17 ` Christoph Hellwig
2013-06-19 14:35 ` Ben Myers
2013-06-19 14:44 ` Christoph Hellwig
2013-06-19 14:54 ` Ric Wheeler
2013-06-19 15:47 ` Ben Myers
2013-06-19 23:33 ` Dave Chinner
2013-06-20 19:14 ` Ben Myers [this message]
2013-06-20 19:31 ` Chandra Seetharaman
2013-06-19 22:54 ` Dave Chinner
2013-06-20 4:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620191433.GY32736@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=rwheeler@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox