Re: [PATCH] xfstests: 313,314: user namespace uid/gids in inode, ACL

Dave Chinner
2013-06-26T01:10:27Z

On Tue, Jun 25, 2013 at 03:34:43PM -0400, Dwight Engen wrote:
> These tests verify that the uid/gids in an inode and in ACLs get translated
> from/to a user namespace to/from disk correctly.
>
> I had to use getfacl instead of the chacl -l because I need numeric uids
> to make the output consistent.
>
> A new program nsexec was added to facilitate creating/entering a user
> namespace for testing. The orignal source for the program is
> https://lwn.net/Articles/539940. I added the -s option to become "root"
> in the user namespace.
>
> Tested against btrfs, ext4, and xfs with my proposed user namespace changes.

Can you split it out into a patch per test? It's easier to review
that way...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com