From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/6] xfstests: generic/193 runs tests in wrong location
Date: Tue, 25 Jun 2013 14:49:20 -0500 [thread overview]
Message-ID: <20130625194920.GC20932@sgi.com> (raw)
In-Reply-To: <1370610398-14630-2-git-send-email-david@fromorbit.com>
On Fri, Jun 07, 2013 at 11:06:33PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> generic/193 runs the test in $here - the root of the xfstests source
> tree/installation. IOWs, it doesn't test the filesystem on either
> the TEST_DIR or SCRATCH_MNT, and so it not testing the filesystem
> we think it is testing. Bad. Fixing this is the majority of the
> change - introducing $test_root and $test_user for the files with
> different owners, and then redirecting error output and filtering
> the output appropriately.
>
> And then add checks that truncate clears the suid/sgid bits
> appropriately, somethign that has never been tested on XFS (and
> likely other filesystems) so will cause kernels between 3.1 and 3.9
> to assert fail as Dave Jones has recently reported.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good. The behavior you outlined regarding suid/sgid bits matches that of
should_remove_suid().
Reviewed-by: Ben Myers <bpm@sgi.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-25 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 13:06 [PATCH 0/6] xfstests: various fixes Dave Chinner
2013-06-07 13:06 ` [PATCH 1/6] xfstests: generic/193 runs tests in wrong location Dave Chinner
2013-06-25 19:49 ` Ben Myers [this message]
2013-06-07 13:06 ` [PATCH 2/6] xfstests: ensure all mkfs output is redirected properly Dave Chinner
2013-06-07 13:06 ` [PATCH 3/6] xfstests: xfs/253 doesn't use seqres correctly Dave Chinner
2013-06-25 20:27 ` Ben Myers
2013-06-07 13:06 ` [PATCH 4/6] xfstests: Make 204 work with different block and inode sizes Dave Chinner
2013-06-07 13:06 ` [PATCH 5/6] xfstests: New _require_* tests for CRC enabled filesystems Dave Chinner
2013-10-17 21:24 ` Eric Sandeen
2013-10-18 2:58 ` Dave Chinner
2013-06-07 13:06 ` [PATCH 6/6] xfstests: add a multithreaded mode to bstat Dave Chinner
2013-10-17 21:29 ` Eric Sandeen
2013-10-18 3:00 ` Dave Chinner
2013-10-18 3:39 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625194920.GC20932@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox