From: Ben Myers <bpm@sgi.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fsync-tester: fix pwrite() return check and disable direct for test 19
Date: Tue, 25 Jun 2013 15:47:09 -0500 [thread overview]
Message-ID: <20130625204709.GE20932@sgi.com> (raw)
In-Reply-To: <1370999583-16725-1-git-send-email-jbacik@fusionio.com>
On Tue, Jun 11, 2013 at 09:13:03PM -0400, Josef Bacik wrote:
> Test 19 in direct mode was failing on xfs because it was not actually doing the
> write because the writes were not sectorsize aligned. This test is to test
> btrfs's inline extent fsync()ing so the writes won't be sectorsize aligned, and
> inline extents will fall back to buffered anyway so direct mode is meaningless
> for this test. So just check if we are test 19 and disable direct mode so we
> don't have to change the golden output. Also change test_five() to compare
> against a ssize_t instead of a size_t since apparently comparing against size_t
> makes it cast the return value of pwrite() to size_t which screws up the error
> case, so instead of seeing the pwrite() error on xfs which would have explained
> this all it appeared as if it was succeeding and screwing up the fsync(), which
> unfortunately wasted a bit of Daves time. This patch should fix all this up.
> Thanks,
>
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-06-25 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 1:13 [PATCH] xfstests: fsync-tester: fix pwrite() return check and disable direct for test 19 Josef Bacik
2013-06-12 2:35 ` Dave Chinner
2013-06-12 2:48 ` Dave Chinner
2013-06-25 20:47 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625204709.GE20932@sgi.com \
--to=bpm@sgi.com \
--cc=jbacik@fusionio.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox