From: Ben Myers <bpm@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: fix make deb
Date: Tue, 25 Jun 2013 17:01:23 -0500 [thread overview]
Message-ID: <20130625220123.GG20932@sgi.com> (raw)
In-Reply-To: <1371526854-15761-1-git-send-email-david@fromorbit.com>
On Tue, Jun 18, 2013 at 01:40:53PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Commit 48212a30 ("xfsprogs: update 'make deb' to use tarball) fixed
> a bunch of problems with making the source tarball for releases.
> However, it broke the debian package builds in a way I hadn't
> noticed until I rewrote my CI system build script.
>
> I noticed that the CI system wasn't building from a pristine
> workarea, and instead was just updating the old workarea and running
> 'make deb'. I added a 'make realclean' to remove all previous state
> from the workarea, and then 'make deb' started failing with errors
> building the tarball because po/xfsprogs.pot didn't have a build
> rule
>
> The above commit removed the pre-build of the translations target,
> and instead made the translation build target a dependency of
> building the the tarball. Hence the lack of a build rule of the
> translations causes the source tarball build to fail.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
My systems seem not to be having this problem. They seem to be building
xfsprogs.pot due to the dependancy through SRCDIR->SRCTAR->SRCTARINC. Can you
post the error?
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-25 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 3:40 [PATCH] xfsprogs: fix make deb Dave Chinner
2013-06-25 22:01 ` Ben Myers [this message]
2013-06-26 2:41 ` Dave Chinner
2013-06-26 16:08 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625220123.GG20932@sgi.com \
--to=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox