public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo
Date: Fri, 28 Jun 2013 13:31:04 -0500	[thread overview]
Message-ID: <20130628183104.GY20932@sgi.com> (raw)
In-Reply-To: <1372443273.8341.207.camel@chandra-dt.ibm.com>

Hey Chandra,

On Fri, Jun 28, 2013 at 01:14:33PM -0500, Chandra Seetharaman wrote:
> On Fri, 2013-06-28 at 11:30 -0500, Ben Myers wrote:
> > Hey Chandra,
> > 
> > On Thu, Jun 27, 2013 at 05:25:08PM -0500, Chandra Seetharaman wrote:
> > > In preparation for combined pquota/gquota support, do some
> > > whitespace cleanups.
> > > 
> > > Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
> > 
> > Wow.  Putting this in a patch by itself really puts it into stark
> > relief.
> > 
> > If we pull this in we're representing that some tabs and the alignment
> > of the fields is more valuable than the comments?  I'm fairly certain I
> 
> 
> If you put it that way, it does sound not correct, and I would agree
> with you too :). 
> 
> But, IMO, it has to be more subjective than that. The comments removed,
> IMO, add no additional value (the field name conveys the same
> information). You can see that I left alone the comments that provide
> some value.

I did notice that you kept some of the comments.  However, I am finding some of
the removed ones to be useful too.  I think if you try to look at this
structure with the eyes of a newbie the comments do help you.  e.g.
di_btimelimit doesn't carry much meaning for me out of context, and the comment
is helping me, at least.  Not everyone is quite so moronic as me, though.  ;)

> > don't agree that's the case...
> > 
> > I'm sorry for your trouble, but I think I should pass on this one.  Do
> > you agree?
> > 
> 
> In effect, the code does look better (than I found it :) at the cost of
> removal of redundant comments.
> 
> If you still don't want to include, I would accept your decision.

Thanks.  I really would prefer to keep them.  FWIW, the rest of your patch set
doesn't appear to be adversely affected by doing so.

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-06-28 18:31 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 22:25 [PATCH v10 00/11] Allow pquota and gquota to be used together Chandra Seetharaman
2013-06-27 22:25 ` [PATCH v10 01/11] xfs: Define a new function xfs_is_quota_inode() Chandra Seetharaman
2013-06-27 22:43   ` Ben Myers
2013-06-27 22:25 ` [PATCH v10 02/11] xfs: Replace macro XFS_DQUOT_TREE with a function Chandra Seetharaman
2013-06-27 23:19   ` Ben Myers
2013-06-27 22:25 ` [PATCH v10 03/11] xfs: Replace macro XFS_DQ_TO_QIP " Chandra Seetharaman
2013-06-27 23:23   ` Ben Myers
2013-06-27 22:25 ` [PATCH v10 04/11] xfs: Code cleanup and removal of some typedef usage Chandra Seetharaman
2013-06-27 23:50   ` Ben Myers
2013-06-27 22:25 ` [PATCH v10 05/11] xfs: Do some whitespace cleanup in the data structure xfs_quotainfo Chandra Seetharaman
2013-06-28 16:30   ` Ben Myers
2013-06-28 18:14     ` Chandra Seetharaman
2013-06-28 18:31       ` Ben Myers [this message]
2013-06-27 22:25 ` [PATCH v10 06/11] xfs: Change xfs_dquot_acct to be a 2-dimensional array Chandra Seetharaman
2013-06-28 19:06   ` Ben Myers
2013-06-27 22:25 ` [PATCH v10 07/11] xfs: Remove incore use of XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD Chandra Seetharaman
2013-06-28 22:36   ` Ben Myers
2013-06-27 22:25 ` [PATCH v10 08/11] xfs: Add pquota fields where gquota is used Chandra Seetharaman
2013-07-10 21:39   ` Ben Myers
2013-07-10 21:46     ` Chandra Seetharaman
2013-07-11  1:23       ` Dave Chinner
2013-07-11  4:05         ` Chandra Seetharaman
2013-06-27 22:25 ` [PATCH v10 09/11] xfs: Start using pquotaino from the superblock Chandra Seetharaman
2013-07-01  2:06   ` Dave Chinner
2013-07-01 17:59     ` Chandra Seetharaman
2013-07-03 17:12       ` Chandra Seetharaman
2013-07-04  1:35         ` Dave Chinner
2013-06-27 22:25 ` [PATCH v10 10/11] quota: Add proper versioning support to fs_quota_stat Chandra Seetharaman
2013-07-10 15:55   ` Ben Myers
2013-07-10 16:26     ` Jan Kara
2013-07-10 18:47       ` Ben Myers
2013-07-10 21:52         ` Jan Kara
2013-07-10 20:49       ` Chandra Seetharaman
2013-07-10 21:54         ` Jan Kara
2013-07-11  1:45         ` Dave Chinner
2013-07-11  4:16           ` Chandra Seetharaman
2013-07-11  7:18             ` Dave Chinner
2013-07-11  7:51             ` Steven Whitehouse
2013-06-27 22:25 ` [PATCH v10 11/11] xfs: Use new qs_pquota field in fs_quota_stat for Q_XGETQSTAT Chandra Seetharaman
2013-06-28 22:53 ` [PATCH v10 00/11] Allow pquota and gquota to be used together Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130628183104.GY20932@sgi.com \
    --to=bpm@sgi.com \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox