From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 01/15] xfs: update mount options documentation
Date: Sat, 29 Jun 2013 12:38:04 +1000 [thread overview]
Message-ID: <20130629023804.GE9047@dastard> (raw)
In-Reply-To: <20130628193959.GC20932@sgi.com>
On Fri, Jun 28, 2013 at 02:39:59PM -0500, Ben Myers wrote:
> Hey Dave,
>
> On Fri, Jun 28, 2013 at 12:32:04PM +1000, Dave Chinner wrote:
> > On Fri, Jun 28, 2013 at 12:09:12PM +1000, Dave Chinner wrote:
> > > On Thu, Jun 27, 2013 at 02:08:31PM -0500, Ben Myers wrote:
> > > > Hey Dave,
> > > >
> > > > On Thu, Jun 27, 2013 at 09:48:14AM -0500, Ben Myers wrote:
> > > > > On Thu, Jun 27, 2013 at 04:04:45PM +1000, Dave Chinner wrote:
> > > > > > From: Dave Chinner <dchinner@redhat.com>
> > > > > >
> > > > > > Because it's horribly out of date.
> > > > > >
> > > > > > And mark various deprecated options as deprecated and give them a
> > > > > > removal date.
> > > > > >
> > > > > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > > > > > Reviewed-by: Mark Tinguely <tinguely@sgi.com>
> > > > >
> > > > > Regarding removal of these mount options and sysctls: initially these all look
> > > > > pretty reasonable but we need to be very careful here. I've read some
> > > > > discussions on lkml that seem to suggest that such interfaces which have been
> > > > > exported to userspace shouldn't be removed at all. Not that I want to keep
> > > > > around a bunch of worn out interfaces...
> > > > >
> > > > > Applied.
> > > >
> > > > On second thought... Not pushed.
> > > >
> > > > I'm going to hold off on pushing this one to oss for now because I'm just not
> > > > comfortable with it yet. I can pull this in sans the removal notices if you
> > > > want. Lets discuss whether the removal of deprecated mount options and sysctls
> > > > is acceptable before announcing an intention to remove them. I'm trending no,
> > > > but I can be flexible if this really is ok.
> > >
> > > Mount options are perfectly fine to be removed - they've been given
> > > deprecated warnings for quite some time now (the most recent is the
> > > delaylog which has been doing that since 3.1 IIRC). So they are all
> > > fine to actually remove - 12 months warning is usually considered
> > > sufficient.
> > >
> > > As to the sysctls - they haven't had any effect since 3.5 when the
> > > xfsbufd was removed, so it's time to mark them deprecated so we can
> > > remove them in a year's time. That gives anyone using them
> > > (including distros) plenty of time to fix whatever is using them
> > > before they get removed.
> > >
> > > > I'm thinking of the 3.3 glusterfs and 3.8 pulseaudio reakeage. And I would
> > > > really like to have a nice holiday weekend. ;)
> > >
> > > I think you're being overly paranoid here - I'm simply following the
> > > normal deprecation protocol here....
> >
> > Documenation/ABI/README:
> >
> > We have four different levels of ABI stability, as shown by the four
> > different subdirectories in this location. Interfaces may chang levels
> > of stability according to the rules described below.
> > ....
> > obsolete/
> > This directory documents interfaces that are still remaining in
> > the kernel, but are marked to be removed at some later point in
> > time. The description of the interface will document the reason
> > why it is obsolete and when it can be expected to be removed.
> >
> > I think you'll find that what I done follows this policy.
>
> Thanks. That's exactly the sort of doc I am looking for. I'll check it out.
> I really just want to make sure that we're not going to be breaking userspace
> by removing these...
>
> > If you really want, I'll move them to Documenation/ABI/obsolete. And, of
> > course, if removing them proves to be a problem, as Eric said we can always
> > reinstate them or remove the deprecation notices.
>
> I forgot to mention that noatime seems to be missing now. Was that intentional?
Yes - it's not an XFS mount option - it's handled by the VFS and
documented as a common mount option for all filesystems just like
nodiratime, relatime, strictatime, sync, dirsync, nosuid, noexec,
etc. IOWs, there's no need to document it as an XFS specific mount
option....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-29 2:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 6:04 [PATCH 00/15] xfs: patchset for 3.11 Dave Chinner
2013-06-27 6:04 ` [PATCH 01/15] xfs: update mount options documentation Dave Chinner
2013-06-27 14:48 ` Ben Myers
2013-06-27 19:08 ` Ben Myers
2013-06-28 2:09 ` Dave Chinner
2013-06-28 2:32 ` Dave Chinner
2013-06-28 15:39 ` Geoffrey Wehrman
2013-06-28 16:49 ` Eric Sandeen
2013-06-28 19:58 ` Geoffrey Wehrman
2013-06-28 17:27 ` Ric Wheeler
2013-06-28 19:39 ` Ben Myers
2013-06-29 2:38 ` Dave Chinner [this message]
2013-06-28 2:18 ` Eric Sandeen
2013-06-28 20:46 ` Ben Myers
2013-06-27 6:04 ` [PATCH 02/15] xfs: add pluging for bulkstat readahead Dave Chinner
2013-06-27 6:04 ` [PATCH 03/15] xfs: plug directory buffer readahead Dave Chinner
2013-06-27 6:04 ` [PATCH 04/15] xfs: don't use speculative prealloc for small files Dave Chinner
2013-06-27 6:04 ` [PATCH 05/15] xfs: don't do IO when creating an new inode Dave Chinner
2013-06-27 6:04 ` [PATCH 06/15] xfs: xfs_ifree doesn't need to modify the inode buffer Dave Chinner
2013-06-27 6:04 ` [PATCH 07/15] xfs: Introduce ordered log vector support Dave Chinner
2013-06-27 6:04 ` [PATCH 08/15] xfs: Introduce an ordered buffer item Dave Chinner
2013-06-27 6:04 ` [PATCH 09/15] xfs: Inode create log items Dave Chinner
2013-06-27 6:04 ` [PATCH 10/15] xfs: Inode create transaction reservations Dave Chinner
2013-06-27 6:04 ` [PATCH 11/15] xfs: Inode create item recovery Dave Chinner
2013-06-27 6:04 ` [PATCH 12/15] xfs: Use inode create transaction Dave Chinner
2013-06-27 6:04 ` [PATCH 13/15] xfs: remove local fork format handling from xfs_bmapi_write() Dave Chinner
2013-06-27 6:04 ` [PATCH 14/15] xfs: dquot log reservations are too small Dave Chinner
2013-06-27 14:38 ` Mark Tinguely
2013-06-28 17:18 ` Chandra Seetharaman
2013-06-29 2:42 ` Dave Chinner
2013-07-09 19:31 ` Ben Myers
2013-07-09 20:39 ` Dave Chinner
2013-07-09 20:42 ` Ben Myers
2013-06-27 6:04 ` [PATCH 15/15] xfs: implement inode change count Dave Chinner
2013-06-27 15:06 ` Mark Tinguely
2013-06-28 16:07 ` Chandra Seetharaman
2013-06-28 18:00 ` Ben Myers
2013-06-27 19:48 ` [PATCH 00/15] xfs: patchset for 3.11 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130629023804.GE9047@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox