From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: clean up unused codes at xfs_bulkstat()
Date: Tue, 2 Jul 2013 20:30:46 +1000 [thread overview]
Message-ID: <20130702103046.GD14996@dastard> (raw)
In-Reply-To: <51D18964.2030708@oracle.com>
On Mon, Jul 01, 2013 at 09:51:32PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> There are some unused codes at xfs_bulkstat():
>
> - Variable bp is defined to point to the on-disk inode cluster
> buffer, but it proved to be of no practical help.
>
> - We process the chunks of good inodes which were fetched by iterating
> btree records from an AG. When processing inodes from each chunk,
> the code recomputing agbno if run into the first inode of a cluster,
> however, the agbno is not being used thereafter.
>
> This patch tries to clean up those things.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-07-02 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 13:51 [PATCH] xfs: clean up unused codes at xfs_bulkstat() Jeff Liu
2013-07-02 10:30 ` Dave Chinner [this message]
2013-07-09 20:37 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702103046.GD14996@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox