From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: check on-disk (not incore) btree root size in dfrag.c
Date: Tue, 9 Jul 2013 13:22:07 -0500 [thread overview]
Message-ID: <20130709182206.GS20932@sgi.com> (raw)
In-Reply-To: <51DC39AC.4090003@sandeen.net>
On Tue, Jul 09, 2013 at 11:26:20AM -0500, Eric Sandeen wrote:
> On 6/20/13 12:09 PM, Ben Myers wrote:
> > On Wed, Jun 19, 2013 at 04:51:41PM -0500, Eric Sandeen wrote:
> >> On 3/27/12 3:40 PM, Eric Sandeen wrote:
> >>> xfs_swap_extents_check_format() contains checks to make sure that
> >>> original and the temporary files during defrag are compatible;
> >>> Gabriel VLASIU ran into a case where xfs_fsr returned EINVAL
> >>> because the tests found the btree root to be of size 120,
> >>> while the fork offset was only 104; IOW, they overlapped.
> >>>
> >>> However, this is just due to an error in the
> >>> xfs_swap_extents_check_format() tests, because it is checking
> >>> the in-memory btree root size against the on-disk fork offset.
> >>> We should be checking the on-disk sizes in both cases.
> >>>
> >>> This patch adds a new macro to calculate this size, and uses
> >>> it in the tests.
> >>>
> >>> With this change, the filesystem image provided by Gabriel
> >>> allows for proper file degragmentation.
> >>
> >> I think this and the followup patch 2/1 got lost.
> >>
> >> Ben, any idea?
> >
> > Yeah. Sorry Eric.
>
> I see the first patch is now merged. Can you please also merge the
> 2nd patch? It is also reviewed already.
Patch still looks good in light of the crc work. Applied.
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-07-09 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 20:40 [PATCH] xfs: check on-disk (not incore) btree root size in dfrag.c Eric Sandeen
2012-03-27 20:50 ` Eric Sandeen
2012-03-27 21:16 ` Dave Chinner
2012-03-28 17:21 ` [PATCH 2/1] xfs: use XFS_BMAP_BMDR_SPACE vs. XFS_BROOT_SIZE_ADJ Eric Sandeen
2012-03-29 0:55 ` Dave Chinner
2013-06-19 21:51 ` [PATCH] xfs: check on-disk (not incore) btree root size in dfrag.c Eric Sandeen
2013-06-20 17:09 ` Ben Myers
2013-07-09 16:26 ` Eric Sandeen
2013-07-09 18:22 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709182206.GS20932@sgi.com \
--to=bpm@sgi.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox