From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 0C8317F37 for ; Fri, 12 Jul 2013 09:28:02 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id D83B28F8033 for ; Fri, 12 Jul 2013 07:27:58 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 24IE0PVXllFYRh0D for ; Fri, 12 Jul 2013 07:27:58 -0700 (PDT) Date: Fri, 12 Jul 2013 11:27:52 -0300 From: Carlos Maiolino Subject: Re: [PATCH] xfs: Initialize all quota inodes to be NULLFSINO Message-ID: <20130712142751.GA11446@andromeda.usersys.redhat.com> References: <1373593665.20769.10.camel@chandra-dt.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1373593665.20769.10.camel@chandra-dt.ibm.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Chandra Seetharaman Cc: XFS mailing list On Thu, Jul 11, 2013 at 08:47:45PM -0500, Chandra Seetharaman wrote: > > mkfs doesn't initialize the quota inodes to NULLFSINO as it > does for the other internal inodes. This leads to check for two > values (0 and NULLFSINO) to make sure if a quota inode is > valid. > > Solve that problem by initializing the values to NULLFSINO > if they are 0. > > Note that these values are not written back to on-disk > superblock unless some quota is enabled on the filesystem. > > Signed-off-by: Chandra Seetharaman > --- > fs/xfs/xfs_mount.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c > index 2b0ba35..8b95933 100644 > --- a/fs/xfs/xfs_mount.c > +++ b/fs/xfs/xfs_mount.c > @@ -572,6 +572,18 @@ out_unwind: > static void > xfs_sb_quota_from_disk(struct xfs_sb *sbp) > { > + /* > + * older mkfs doesn't initialize quota inodes to NULLFSINO, > + * which leads to two values for a quota inode to be invalid: > + * 0 and NULLFSINO. Fix it. > + */ > + if (sbp->sb_uquotino == 0) > + sbp->sb_uquotino = NULLFSINO; > + if (sbp->sb_gquotino == 0) > + sbp->sb_gquotino = NULLFSINO; > + if (sbp->sb_pquotino == 0) > + sbp->sb_pquotino = NULLFSINO; > + > if (sbp->sb_qflags & XFS_OQUOTA_ENFD) > sbp->sb_qflags |= (sbp->sb_qflags & XFS_PQUOTA_ACCT) ? > XFS_PQUOTA_ENFD : XFS_GQUOTA_ENFD; > -- > 1.7.1 > Hi, in this case, wouldn't be better to make mkfs initialize the quota inodes with NULLFSINO instead of need to convert it into kernel? -- Carlos _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs