From: Dave Chinner <david@fromorbit.com>
To: Dwight Engen <dwight.engen@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4 4/7] xfs: convert kuid_t to/from uid_t for internal structures
Date: Fri, 19 Jul 2013 15:35:32 +1000 [thread overview]
Message-ID: <20130719053532.GV11674@dastard> (raw)
In-Reply-To: <20130717114734.4d2ca6fb@oracle.com>
On Wed, Jul 17, 2013 at 11:47:34AM -0400, Dwight Engen wrote:
> Use uint32 from init_user_ns for xfs internal uid/gid
> representation in xfs_icdinode, xfs_dqid_t.
>
> Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
> ---
> fs/xfs/xfs_inode.c | 6 +++---
> fs/xfs/xfs_iops.c | 38 ++++++++++++++++++++------------------
> fs/xfs/xfs_qm.c | 10 +++++-----
> fs/xfs/xfs_quota.h | 11 ++++++-----
> fs/xfs/xfs_symlink.c | 6 ++++--
> fs/xfs/xfs_vnodeops.c | 8 +++++---
> 6 files changed, 43 insertions(+), 36 deletions(-)
Looks good. It's clear now that here is a difference between what
is held in the VFS inode and the XFS inode core....
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-07-19 5:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 15:47 [PATCH v4 4/7] xfs: convert kuid_t to/from uid_t for internal structures Dwight Engen
2013-07-19 5:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719053532.GV11674@dastard \
--to=david@fromorbit.com \
--cc=dwight.engen@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox