* [PATCH] xfs_metadump: manpage fix regarding frozen fs
@ 2013-07-16 2:16 Eric Sandeen
2013-07-19 20:20 ` Ben Myers
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2013-07-16 2:16 UTC (permalink / raw)
To: 'linux-xfs@oss.sgi.com'
The xfs_metadump manpage states that metadump works
on a frozen filesystem; it does not. In fact, there is
no way to detect a frozen filesystem, so we can't make it
work, either.
So just remove this from the manpage; unmounted or RO
mounted is what is enforced by xfs_metadump.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/man/man8/xfs_metadump.8 b/man/man8/xfs_metadump.8
index 26cea97..4fa1b1c 100644
--- a/man/man8/xfs_metadump.8
+++ b/man/man8/xfs_metadump.8
@@ -32,10 +32,8 @@ is \-, then the output is sent to stdout. This allows the output to be
redirected to another program such as a compression application.
.PP
.B xfs_metadump
-should only be used to copy unmounted filesystems, read-only mounted
-filesystems, or frozen filesystems (see
-.BR xfs_freeze (8)).
-Otherwise, the generated dump could be inconsistent or corrupt.
+may only be used to copy unmounted filesystems, or read-only mounted
+filesystems.
.PP
.B xfs_metadump
does not alter the source filesystem in any way. The
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_metadump: manpage fix regarding frozen fs
2013-07-16 2:16 [PATCH] xfs_metadump: manpage fix regarding frozen fs Eric Sandeen
@ 2013-07-19 20:20 ` Ben Myers
2013-07-19 23:34 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Ben Myers @ 2013-07-19 20:20 UTC (permalink / raw)
To: Eric Sandeen; +Cc: 'linux-xfs@oss.sgi.com'
Hey Eric,
On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote:
> The xfs_metadump manpage states that metadump works
> on a frozen filesystem; it does not. In fact, there is
> no way to detect a frozen filesystem, so we can't make it
> work, either.
>
> So just remove this from the manpage; unmounted or RO
> mounted is what is enforced by xfs_metadump.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
I gave this a try and it *seemed* to work fine on a frozen filesystem.
Can you provide a bit of detail about why xfs_metadump doesn't work on
frozen filesystems? What am I missing?
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_metadump: manpage fix regarding frozen fs
2013-07-19 20:20 ` Ben Myers
@ 2013-07-19 23:34 ` Eric Sandeen
2013-07-22 21:22 ` Ben Myers
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2013-07-19 23:34 UTC (permalink / raw)
To: Ben Myers; +Cc: linux-xfs@oss.sgi.com, Eric Sandeen
On Jul 19, 2013, at 3:20 PM, Ben Myers <bpm@sgi.com> wrote:
> Hey Eric,
>
> On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote:
>> The xfs_metadump manpage states that metadump works
>> on a frozen filesystem; it does not. In fact, there is
>> no way to detect a frozen filesystem, so we can't make it
>> work, either.
>>
>> So just remove this from the manpage; unmounted or RO
>> mounted is what is enforced by xfs_metadump.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> I gave this a try and it *seemed* to work fine on a frozen filesystem.
> Can you provide a bit of detail about why xfs_metadump doesn't work on
> frozen filesystems? What am I missing?
>
Hum, when I tried it it didn't work. I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work?
-Eric
> Thanks,
> Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_metadump: manpage fix regarding frozen fs
2013-07-19 23:34 ` Eric Sandeen
@ 2013-07-22 21:22 ` Ben Myers
0 siblings, 0 replies; 4+ messages in thread
From: Ben Myers @ 2013-07-22 21:22 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs@oss.sgi.com
On Fri, Jul 19, 2013 at 07:34:57PM -0400, Eric Sandeen wrote:
> On Jul 19, 2013, at 3:20 PM, Ben Myers <bpm@sgi.com> wrote:
>
> > Hey Eric,
> >
> > On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote:
> >> The xfs_metadump manpage states that metadump works
> >> on a frozen filesystem; it does not. In fact, there is
> >> no way to detect a frozen filesystem, so we can't make it
> >> work, either.
> >>
> >> So just remove this from the manpage; unmounted or RO
> >> mounted is what is enforced by xfs_metadump.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >
> > I gave this a try and it *seemed* to work fine on a frozen filesystem.
> > Can you provide a bit of detail about why xfs_metadump doesn't work on
> > frozen filesystems? What am I missing?
> >
>
> Hum, when I tried it it didn't work. I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work?
Gah. As we discussed on IRC, I was wrong. So, so wrong.
Reviewed-by: Ben Myers <bpm@sgi.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-22 21:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-16 2:16 [PATCH] xfs_metadump: manpage fix regarding frozen fs Eric Sandeen
2013-07-19 20:20 ` Ben Myers
2013-07-19 23:34 ` Eric Sandeen
2013-07-22 21:22 ` Ben Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox