[PATCH] xfstests: skip generic/192 if noatime is set

[PATCH] xfstests: skip generic/192 if noatime is set

[David Sterba]

Test generic/192 fails if noatime is set

generic/192
    -delta1 - access time after sleep in-core: 40
    -delta2 - access time after sleep on-disk: 40
    +delta1 - access time after sleep in-core: 0
    +delta2 - access time after sleep on-disk: 0

but it's pointless to test atime effects with noatime.

Signed-off-by: David Sterba <dsterba@suse.cz>
---
 tests/generic/192 | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/generic/192 b/tests/generic/192
index a40c121..2b4e41c 100755
--- a/tests/generic/192
+++ b/tests/generic/192
@@ -38,6 +38,13 @@ _access_time()
 	stat --format=%X $1
 }
 
+is_noatime_set() {
+	case "$MOUNT_OPTIONS" in
+		*noatime*) return 0;;
+	esac
+	return 1
+}
+
 # get standard environment, filters and checks
 . ./common/rc
 . ./common/filter
@@ -52,6 +59,10 @@ _supported_os Linux
 #delay=45
 delay=40
 
+if is_noatime_set; then
+	_notrun "this test makes no sense with noatime"
+fi
+
 testfile=$TEST_DIR/testfile
 rm -f $testfile
 rm -f $seqres.full
-- 
1.8.2

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: skip generic/192 if noatime is set

[Ben Myers]

On Wed, Jul 03, 2013 at 04:00:05PM +0200, David Sterba wrote:
> Test generic/192 fails if noatime is set
> 
> generic/192
>     -delta1 - access time after sleep in-core: 40
>     -delta2 - access time after sleep on-disk: 40
>     +delta1 - access time after sleep in-core: 0
>     +delta2 - access time after sleep on-disk: 0
> 
> but it's pointless to test atime effects with noatime.
> 
> Signed-off-by: David Sterba <dsterba@suse.cz>

Looks fine.

Reviewed-by: Ben Myers <bpm@sgi.com>

Applied.  Thanks David.

-Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs