From: Dave Chinner <david@fromorbit.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Ben Myers <bpm@sgi.com>, Mark Tinguely <tinguely@sgi.com>,
Stan Hoeppner <stan@hardwarefreak.com>,
xfs@oss.sgi.com
Subject: Re: [Bisected] Corruption of root fs during git bisect of drm system hang
Date: Mon, 22 Jul 2013 20:22:23 +1000 [thread overview]
Message-ID: <20130722102223.GG11674@dastard> (raw)
In-Reply-To: <20130720014836.GZ11674@dastard>
On Sat, Jul 20, 2013 at 11:48:36AM +1000, Dave Chinner wrote:
> On Fri, Jul 19, 2013 at 02:22:35PM +0200, Markus Trippelsdorf wrote:
> > On 2013.07.15 at 08:47 +0200, Markus Trippelsdorf wrote:
> > I've bisected this issue to the following commit:
> >
> > commit cca9f93a52d2ead50b5da59ca83d5f469ee4be5f
> > Author: Dave Chinner <dchinner@redhat.com>
> > Date: Thu Jun 27 16:04:49 2013 +1000
> >
> > xfs: don't do IO when creating an new inode
> >
> > Reverting this commit on top of the Linus tree "solves" all problems for
> > me. IOW I no longer loose my KDE and LibreOffice config files during a
> > crash. Log recovery now works fine and xfs_repair shows no issues.
>
> Thanks for bisecting this, Marcus.
>
> I'll admit, right now it doesn't make a lot of sense to me - I don't
> immediately see a connection between not reading an inode during the
> create phase and unlinked list and directory corruption after a
> crash. But now you've identified a change that might be the cause,
> I have an avenue of investigation I can follow.
>
> Indeed, in the time I've taken to write this mail I've thought of
> 2-3 possible causes that I need to investigate....
Hi Markus, can you test the patch I just posted to the list titled
"xfs: di_flushiter considered harmful" and see if it fixes your
problem? Archive link here:
http://oss.sgi.com/pipermail/xfs/2013-July/028331.html
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-07-22 10:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 9:06 Corruption of root fs during git bisect of drm system hang Markus Trippelsdorf
2013-07-11 0:31 ` Dave Chinner
2013-07-11 3:36 ` Markus Trippelsdorf
2013-07-11 3:58 ` Dave Chinner
2013-07-11 4:12 ` Stan Hoeppner
2013-07-11 9:07 ` Markus Trippelsdorf
2013-07-11 11:28 ` Markus Trippelsdorf
2013-07-11 20:24 ` Stan Hoeppner
2013-07-11 20:40 ` Markus Trippelsdorf
2013-07-11 23:01 ` Stan Hoeppner
2013-07-12 2:38 ` Dave Chinner
2013-07-12 2:17 ` Dave Chinner
2013-07-12 7:07 ` Markus Trippelsdorf
2013-07-13 9:05 ` Markus Trippelsdorf
2013-07-15 2:28 ` Dave Chinner
2013-07-15 6:47 ` Markus Trippelsdorf
2013-07-19 12:22 ` [Bisected] " Markus Trippelsdorf
2013-07-19 12:41 ` Stefan Ring
2013-07-19 12:51 ` Markus Trippelsdorf
2013-07-19 16:02 ` Eric Sandeen
2013-07-19 16:32 ` Markus Trippelsdorf
2013-07-19 19:13 ` Ben Myers
2013-07-19 19:56 ` Markus Trippelsdorf
2013-07-19 20:28 ` Markus Trippelsdorf
2013-07-19 19:23 ` Eric Sandeen
2013-07-19 19:53 ` Markus Trippelsdorf
2013-07-19 21:11 ` Mark Tinguely
2013-07-20 3:18 ` Dave Chinner
2013-07-20 17:21 ` Mark Tinguely
2013-07-21 7:37 ` Dave Chinner
2013-07-20 1:48 ` Dave Chinner
2013-07-22 10:22 ` Dave Chinner [this message]
2013-07-22 10:47 ` Markus Trippelsdorf
2013-07-22 22:54 ` Dave Chinner
2013-07-11 4:15 ` Markus Trippelsdorf
2013-07-11 0:37 ` Stan Hoeppner
2013-07-11 3:47 ` Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722102223.GG11674@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=markus@trippelsdorf.de \
--cc=stan@hardwarefreak.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox