From: Ben Myers <bpm@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: XFS mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: Start using pquotaino from the superblock.
Date: Mon, 22 Jul 2013 14:52:38 -0500 [thread overview]
Message-ID: <20130722195238.GD3111@sgi.com> (raw)
In-Reply-To: <1374273362.8941.2086.camel@chandra-dt.ibm.com>
On Fri, Jul 19, 2013 at 05:36:02PM -0500, Chandra Seetharaman wrote:
> Change from the previous version:
> Addressed Ben's comments
> - removed unnecessary sb_gquotino == NULLFSINO check in
> xfs_sb_quota_to_disk()
> - Changed the fs_quota_stat logic to not fail with EINVAL if
> both gquota and pquota are available. Instead, fill fs_quota_stat
> only with gquota information.
> ----
>
> Start using pquotino and define a macro to check if the
> superblock has pquotino.
>
> Keep backward compatibilty by alowing mount of older superblock
> with no separate pquota inode.
>
> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Looks good!
Reviewed-by: Ben Myers <bpm@sgi.com>
Applied. As much as I'd like to send this in a pull request for -rc3, IMO this
is the sort of material that is most appropriate for a merge window. I think
we'd better wait for 3.12-rc1 merge window to open. Sorry about that.
Thanks,
Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-07-22 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 22:36 [PATCH] xfs: Start using pquotaino from the superblock Chandra Seetharaman
2013-07-22 19:52 ` Ben Myers [this message]
2013-07-22 23:50 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2013-07-12 1:48 Chandra Seetharaman
2013-07-12 18:30 ` Ben Myers
2013-07-12 20:32 ` Chandra Seetharaman
2013-07-13 2:17 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722195238.GD3111@sgi.com \
--to=bpm@sgi.com \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox