From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 925ED7F37 for ; Mon, 22 Jul 2013 14:52:41 -0500 (CDT) Date: Mon, 22 Jul 2013 14:52:38 -0500 From: Ben Myers Subject: Re: [PATCH] xfs: Start using pquotaino from the superblock. Message-ID: <20130722195238.GD3111@sgi.com> References: <1374273362.8941.2086.camel@chandra-dt.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1374273362.8941.2086.camel@chandra-dt.ibm.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Chandra Seetharaman Cc: XFS mailing list On Fri, Jul 19, 2013 at 05:36:02PM -0500, Chandra Seetharaman wrote: > Change from the previous version: > Addressed Ben's comments > - removed unnecessary sb_gquotino == NULLFSINO check in > xfs_sb_quota_to_disk() > - Changed the fs_quota_stat logic to not fail with EINVAL if > both gquota and pquota are available. Instead, fill fs_quota_stat > only with gquota information. > ---- > > Start using pquotino and define a macro to check if the > superblock has pquotino. > > Keep backward compatibilty by alowing mount of older superblock > with no separate pquota inode. > > Signed-off-by: Chandra Seetharaman Looks good! Reviewed-by: Ben Myers Applied. As much as I'd like to send this in a pull request for -rc3, IMO this is the sort of material that is most appropriate for a merge window. I think we'd better wait for 3.12-rc1 merge window to open. Sorry about that. Thanks, Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs