From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <esandeen@redhat.com>
Cc: "linux-xfs@oss.sgi.com" <linux-xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_metadump: manpage fix regarding frozen fs
Date: Mon, 22 Jul 2013 16:22:51 -0500 [thread overview]
Message-ID: <20130722212251.GF3111@sgi.com> (raw)
In-Reply-To: <87CEB35B-5931-49C9-8075-F44851F6E8ED@redhat.com>
On Fri, Jul 19, 2013 at 07:34:57PM -0400, Eric Sandeen wrote:
> On Jul 19, 2013, at 3:20 PM, Ben Myers <bpm@sgi.com> wrote:
>
> > Hey Eric,
> >
> > On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote:
> >> The xfs_metadump manpage states that metadump works
> >> on a frozen filesystem; it does not. In fact, there is
> >> no way to detect a frozen filesystem, so we can't make it
> >> work, either.
> >>
> >> So just remove this from the manpage; unmounted or RO
> >> mounted is what is enforced by xfs_metadump.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >
> > I gave this a try and it *seemed* to work fine on a frozen filesystem.
> > Can you provide a bit of detail about why xfs_metadump doesn't work on
> > frozen filesystems? What am I missing?
> >
>
> Hum, when I tried it it didn't work. I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work?
Gah. As we discussed on IRC, I was wrong. So, so wrong.
Reviewed-by: Ben Myers <bpm@sgi.com>
Applied.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-07-22 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 2:16 [PATCH] xfs_metadump: manpage fix regarding frozen fs Eric Sandeen
2013-07-19 20:20 ` Ben Myers
2013-07-19 23:34 ` Eric Sandeen
2013-07-22 21:22 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722212251.GF3111@sgi.com \
--to=bpm@sgi.com \
--cc=esandeen@redhat.com \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox