[PATCH] xfs_metadump: manpage fix regarding frozen fs

[PATCH] xfs_metadump: manpage fix regarding frozen fs

[Eric Sandeen]

The xfs_metadump manpage states that metadump works
on a frozen filesystem; it does not.  In fact, there is
no way to detect a frozen filesystem, so we can't make it
work, either.

So just remove this from the manpage; unmounted or RO
mounted is what is enforced by xfs_metadump.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/man/man8/xfs_metadump.8 b/man/man8/xfs_metadump.8
index 26cea97..4fa1b1c 100644
--- a/man/man8/xfs_metadump.8
+++ b/man/man8/xfs_metadump.8
@@ -32,10 +32,8 @@ is \-, then the output is sent to stdout. This allows the output to be
 redirected to another program such as a compression application.
 .PP
 .B xfs_metadump
-should only be used to copy unmounted filesystems, read-only mounted
-filesystems, or frozen filesystems (see
-.BR xfs_freeze (8)).
-Otherwise, the generated dump could be inconsistent or corrupt.
+may only be used to copy unmounted filesystems, or read-only mounted
+filesystems.
 .PP
 .B xfs_metadump
 does not alter the source filesystem in any way. The

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_metadump: manpage fix regarding frozen fs

[Ben Myers]

Hey Eric,

On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote:
> The xfs_metadump manpage states that metadump works
> on a frozen filesystem; it does not.  In fact, there is
> no way to detect a frozen filesystem, so we can't make it
> work, either.
> 
> So just remove this from the manpage; unmounted or RO
> mounted is what is enforced by xfs_metadump.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

I gave this a try and it *seemed* to work fine on a frozen filesystem.
Can you provide a bit of detail about why xfs_metadump doesn't work on
frozen filesystems?  What am I missing?

Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_metadump: manpage fix regarding frozen fs

[Eric Sandeen]

On Jul 19, 2013, at 3:20 PM, Ben Myers <bpm@sgi.com> wrote:

> Hey Eric,
> 
> On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote:
>> The xfs_metadump manpage states that metadump works
>> on a frozen filesystem; it does not.  In fact, there is
>> no way to detect a frozen filesystem, so we can't make it
>> work, either.
>> 
>> So just remove this from the manpage; unmounted or RO
>> mounted is what is enforced by xfs_metadump.
>> 
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> 
> I gave this a try and it *seemed* to work fine on a frozen filesystem.
> Can you provide a bit of detail about why xfs_metadump doesn't work on
> frozen filesystems?  What am I missing?
> 

Hum, when I tried it it didn't work.  I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work?

-Eric

> Thanks,
>    Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_metadump: manpage fix regarding frozen fs

[Ben Myers]

On Fri, Jul 19, 2013 at 07:34:57PM -0400, Eric Sandeen wrote:
> On Jul 19, 2013, at 3:20 PM, Ben Myers <bpm@sgi.com> wrote:
> 
> > Hey Eric,
> > 
> > On Mon, Jul 15, 2013 at 09:16:52PM -0500, Eric Sandeen wrote:
> >> The xfs_metadump manpage states that metadump works
> >> on a frozen filesystem; it does not.  In fact, there is
> >> no way to detect a frozen filesystem, so we can't make it
> >> work, either.
> >> 
> >> So just remove this from the manpage; unmounted or RO
> >> mounted is what is enforced by xfs_metadump.
> >> 
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> > 
> > I gave this a try and it *seemed* to work fine on a frozen filesystem.
> > Can you provide a bit of detail about why xfs_metadump doesn't work on
> > frozen filesystems?  What am I missing?
> > 
> 
> Hum, when I tried it it didn't work.  I can retest, but AFAIK there is no way to detect a frozen fs in the first place, so how could it work?

Gah.  As we discussed on IRC, I was wrong.  So, so wrong.

Reviewed-by: Ben Myers <bpm@sgi.com>

Applied.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs