public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Koen De Wit <koen.de.wit@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix _mount_ops_filter() to support $TEST_DIR containing -o
Date: Wed, 24 Jul 2013 18:09:02 -0500	[thread overview]
Message-ID: <20130724230902.GW3111@sgi.com> (raw)
In-Reply-To: <1372801497-3941-1-git-send-email-koen.de.wit@oracle.com>

On Tue, Jul 02, 2013 at 11:44:57PM +0200, Koen De Wit wrote:
> If multiple mount options are given with multiple -o parameters,
> _mount_ops_filter concatenates them by replacing all -o's with a comma
> (except for the first -o).
> 
> If $TEST_DIR contains "-o" (e.g. /mnt/test-os/) you get errors like this:
> 
>    # ./check generic/002
>      mount: mount point /mnt/test,s/ does not exist
>      common/rc: retrying test device mount with external set
>      mount: mount point /mnt/test,s/ does not exist
>      common/rc: could not mount /dev/sdc3 on /mnt/test-os/
> 
> Fix it by only replacing -o's that are preceded by at least one space.
> 
> Signed-off-by: Koen De Wit <koen.de.wit@oracle.com>

Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-07-24 23:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 21:44 [PATCH] xfstests: fix _mount_ops_filter() to support $TEST_DIR containing -o Koen De Wit
2013-07-24 23:09 ` Ben Myers [this message]
2013-08-15 16:33 ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130724230902.GW3111@sgi.com \
    --to=bpm@sgi.com \
    --cc=koen.de.wit@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox