From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 86EB37F37 for ; Thu, 25 Jul 2013 12:28:50 -0500 (CDT) Date: Thu, 25 Jul 2013 12:28:49 -0500 From: Ben Myers Subject: Re: [PATCH 13/48] xfs: shortform directory offsets change for dir3 format Message-ID: <20130725172849.GA3111@sgi.com> References: <1370564771-4929-1-git-send-email-david@fromorbit.com> <1370564771-4929-14-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1370564771-4929-14-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Jun 07, 2013 at 10:25:36AM +1000, Dave Chinner wrote: > From: Dave Chinner > > Because the header size for the CRC enabled directory blocks is > larger, the offset of the first entry into a directory block is > different to the dir2 format. The shortform directory stores the > dirent's offset so that it doesn't change when moving from shortform > to block form and back again, and hence it needs to take into > account the different header sizes to maintain the correct offsets. > > Signed-off-by: Dave Chinner corresponds to commit 6b2647a12a0 xfs_dir2_sf_getdents which is changed in the kernel commit doesn't exist in userspace. Looks good. Reviewed-by: Ben Myers _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs