From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id DA53F7F5F for ; Sat, 27 Jul 2013 20:08:37 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id BA82D8F8033 for ; Sat, 27 Jul 2013 18:08:34 -0700 (PDT) Received: from ipmail05.adl6.internode.on.net (ipmail05.adl6.internode.on.net [150.101.137.143]) by cuda.sgi.com with ESMTP id xNScWQNgSlaqYg39 for ; Sat, 27 Jul 2013 18:08:33 -0700 (PDT) Date: Sun, 28 Jul 2013 11:08:29 +1000 From: Dave Chinner Subject: Re: [PATCH 20/49] xfs: introduce xfs_sb.c for sharing with libxfs Message-ID: <20130728010829.GX13468@dastard> References: <1374215120-7271-1-git-send-email-david@fromorbit.com> <1374215120-7271-21-git-send-email-david@fromorbit.com> <51F4093A.6070308@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51F4093A.6070308@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Mark Tinguely Cc: xfs@oss.sgi.com On Sat, Jul 27, 2013 at 12:54:02PM -0500, Mark Tinguely wrote: > On 07/19/13 01:24, Dave Chinner wrote: > >From: Dave Chinner > > > >xfs_mount.c is shared with userspace, but the only functions that > >are shared are to do with physical superblock manipulations. This > >means that less than 25% of the xfs_mount.c code is actually shared > >with userspace. Move all the superblock functions to xfs_sb.c and > >share that instead with libxfs. > > > >Note that this will leave all the in-core transaction related > >superblock counter modifications in xfs_mount.c as none of that is > >shared with userspace. With a few more small changes, xfs_mount.h > >won't need to be shared with userspace anymore, either. > > > >Signed-off-by: Dave Chinner > >--- > > okay, moves the user sharable functions/headers from xfs_mount.c/h to > xfs_sb.c/h > > couple comments: > > a struct xfs_mount got converted to a xfs_mount_t typedef in > xfs_initialize_perag() def in xfs_mount.h > > brackets were added to a single line if statements in > xfs_sb_quota_from_disk() I'll fix those - I missed them when doing an update. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs