From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 1CCDF29DFB for ; Thu, 1 Aug 2013 16:32:43 -0500 (CDT) Date: Thu, 1 Aug 2013 16:32:42 -0500 From: Ben Myers Subject: Re: [PATCH 28/48] libxfs: determine inode size from version number, not struct xfs_dinode Message-ID: <20130801213242.GC3111@sgi.com> References: <1370564771-4929-1-git-send-email-david@fromorbit.com> <1370564771-4929-29-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1370564771-4929-29-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Jun 07, 2013 at 10:25:51AM +1000, Dave Chinner wrote: > From: Dave Chinner > > xfs_db does not use the same structure types as libxfs when checking > inodes, and so cannot determine the size of the inode core by > passing a struct xfs_dinode to a function. We do, however, know the > raw version number, so we can pass that instead. Convert the code to > passing the inode version rather than a structure. > > Note that this should probably be converted in the kernel code as > well. > > Signed-off-by: Dave Chinner Looks good. Reviewed-by: Ben Myers _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs