From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id E01887CBE for ; Sun, 11 Aug 2013 18:33:53 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id CD7CA8F8037 for ; Sun, 11 Aug 2013 16:33:53 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id DsjkFRdgspfI4GiV for ; Sun, 11 Aug 2013 16:33:52 -0700 (PDT) Date: Mon, 12 Aug 2013 09:33:39 +1000 From: Dave Chinner Subject: ***** SUSPECTED SPAM ***** Re: [PATCH 0/14] xfsprogs: various issues from review Message-ID: <20130811233339.GE12779@dastard> References: <1370564771-4929-1-git-send-email-david@fromorbit.com> <20130806214154.GM3111@sgi.com> <20130808210600.GN3111@sgi.com> <20130808220224.GX3111@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130808220224.GX3111@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ben Myers Cc: Eric Sandeen , xfs@oss.sgi.com On Thu, Aug 08, 2013 at 05:02:24PM -0500, Ben Myers wrote: > On Thu, Aug 08, 2013 at 04:06:01PM -0500, Ben Myers wrote: > > On Tue, Aug 06, 2013 at 04:41:54PM -0500, Ben Myers wrote: > > > On Fri, Jun 07, 2013 at 10:25:23AM +1000, Dave Chinner wrote: > > > > Hi folks, > > > > > > > > This is the latest update of the series of patches tht introduces > > > > CRC support into xfsprogs. Of note, for CRC enabled filesystems; > > > > > > > > - write support for xfs-db is disabled > > > > - obfuscation for metadump is disabled > > > > - xfs_check does nothing ("always succeed") so that xfstests > > > > can run without needing this > > > > - all structures shoul dbe supported for printing in xfs_db > > > > - xfs_repair should be able to fully validate the structure > > > > of a CRC enabled filesystem. > > > > - xfs_repair still ignores CRC validation errors when > > > > reading metadata > > > > - mkfs.xfs enforces limitations on the format of CRC enabled > > > > filesystems (inode size, attr format, projid32bit, etc). > > > > - whenever a v5 superblock is parsed on read by any utility, > > > > it outputs a wanring about it being an experimental > > > > format. > > > > > > > > Bug reports, patches, comments, reviews, etc all welcome. > > > > > > Pulled in 1-48 of the first series and 1-12 of the second. > > > > Here is a patch series that addresses some of my outstanding concerns from > > review. Some may be already fixed in the 2nd series, I'm not sure. Eric also > > mentioned that he put the updated branch through coverity and found some > > defects. There may be some overlap there too. > > > > Some of these are just reminders for myself to make sure certain items are > > addressed eventually. Sorry for the noise. > > I'll stop at 9. The rest of them are notes to myself: > > * xfs_db write support needs to be done Dependent on being able to write crcs. needs xfs_db to be converted to libxfs based IO. > * xfs_metadump obfuscation needs to be done dependent on the same thing as xfs_db write support. > * xfs_mdrestore needs to work Shoul dwork if xfs_metadump works properly. > * xfs_check needs work Probably not. It's deprecated. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs