public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: ***** SUSPECTED SPAM ***** Re: [PATCH 28/49] xfs: move unrealted definitions out of xfs_inode.h
Date: Mon, 12 Aug 2013 10:30:39 +1000	[thread overview]
Message-ID: <20130812003039.GI12779@dastard> (raw)
In-Reply-To: <52001FB7.3010901@sgi.com>

On Mon, Aug 05, 2013 at 04:57:11PM -0500, Mark Tinguely wrote:
> On 07/19/13 01:45, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
> 
> 
> >diff --git a/include/xfs_trans.h b/include/xfs_trans.h
> >index e504103..37aca08 100644
> >--- a/include/xfs_trans.h
> >+++ b/include/xfs_trans.h
> >@@ -89,6 +89,13 @@ struct xfs_log_item_desc {
> >  #define	XFS_ATTR_BTREE_REF	1
> >  #define	XFS_DQUOT_REF		1
> >
> >+/*
> >+ * Flags for xfs_trans_ichgtime().
> >+ */
> >+#define	XFS_ICHGTIME_MOD	0x1	/* data fork modification timestamp */
> >+#define	XFS_ICHGTIME_CHG	0x2	/* inode field change timestamp */
> >+#define	XFS_ICHGTIME_CREATE	0x4	/* inode create timestamp */
> >+
> 
> in the kernel patch 13/49 these entries go into xfs_log_format.h

Right, in the updated kernel series xfs_trans.h is no longer shared
with userspace, and this patch series doesn't reflect that. it needs
updating.

> >  #ifdef __KERNEL__
> >
> >  struct xfs_buf;
> >diff --git a/libxfs/xfs.h b/libxfs/xfs.h
> >index 7149c09..1a01c61 100644
> >--- a/libxfs/xfs.h
> >+++ b/libxfs/xfs.h
> >@@ -68,6 +68,9 @@ typedef __uint32_t		inst_t;		/* an instruction */
> >
> >  #define IHOLD(ip)			((void) 0)
> >
> >+#define XFS_IGET_CREATE			0x1
> >+#define XFS_IGET_UNTRUSTED		0x2
> >+
> >  /* stop unused var warnings by assigning mp to itself */
> >  #define XFS_CORRUPTION_ERROR(e,l,mp,m)	do { \
> >  	(mp) = (mp); \
> 
> in the kernel patch 13/49 these entries go into xfs_icache.h

Yup, they go into a kernel only header file. Userspace can define
them how they want as xfs_iget() has different requirements and a
completely different implementation in userspace.

> 
> --Mark.
> 

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-08-12  0:30 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  6:44 [PATCH 00/49] xfsprogs: patches for crc-dev branch Dave Chinner
2013-07-19  6:44 ` [PATCH 01/49] xfsprogs: introduce xfs_icreate.h Dave Chinner
2013-08-01 18:07   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 02/49] xfsprogs: port inode create transaction changes Dave Chinner
2013-08-01 19:01   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 03/49] xfsprogs: teach logprint about icreate transaction Dave Chinner
2013-08-01 21:30   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 04/49] libxfs: fix directory/attribute format issues Dave Chinner
2013-08-02 13:10   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 05/49] libxfs: ensure btree root split sets blkno correctly Dave Chinner
2013-08-02 13:12   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 06/49] libxfs: fix byte swapping on constants Dave Chinner
2013-08-02 13:51   ` Mark Tinguely
2013-08-12  0:03     ` ***** SUSPECTED SPAM ***** " Dave Chinner
2013-07-19  6:44 ` [PATCH 07/49] libxfs: sync xfs_da_btree.c Dave Chinner
2013-08-02 14:22   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 08/49] libxfs: update xfs_alloc to current kernel version Dave Chinner
2013-08-02 15:11   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 09/49] libxfs: sync attr code with kernel Dave Chinner
2013-08-02 16:02   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 10/49] libxfs: sync dir2 kernel differences Dave Chinner
2013-08-02 16:25   ` Mark Tinguely
2013-08-08 22:04   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 11/49] libxfs: sync xfs_ialloc.c to the kernel code Dave Chinner
2013-08-02 18:08   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 12/49] xfsprogs: define min/max once and use them everywhere Dave Chinner
2013-08-02 18:42   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 13/49] libxfs: fix compile warnings Dave Chinner
2013-08-02 21:13   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 14/49] xfs: remove local fork format handling from xfs_bmapi_write() Dave Chinner
2013-08-02 21:42   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 15/49] libxfs: local to remote format support of remote symlinks Dave Chinner
2013-08-02 22:22   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 16/49] xfs: separate out log format definitions Dave Chinner
2013-08-03 15:15   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 17/49] xfs: split out inode log item format definition Dave Chinner
2013-08-03 15:23   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 18/49] xfs: split out buf log item format definitions Dave Chinner
2013-08-04 23:37   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 19/49] xfs: split out inode log item format definition Dave Chinner
2013-08-04 23:41   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 20/49] xfs: separate dquot on disk format definitions out of xfs_quota.h Dave Chinner
2013-08-05 14:18   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 21/49] xfs: separate icreate log format definitions from xfs_icreate_item.h Dave Chinner
2013-08-05 14:27   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 22/49] xfs: split out on-disk transaction definitions Dave Chinner
2013-08-05 15:22   ` Mark Tinguely
2013-08-05 15:24     ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 23/49] xfs: introduce xfs_rtalloc_defs.h Dave Chinner
2013-08-05 18:53   ` Mark Tinguely
2013-07-19  6:44 ` [PATCH 24/49] xfs: introduce xfs_quota_defs.h Dave Chinner
2013-08-05 19:09   ` Mark Tinguely
2013-08-12  0:24     ` ***** SUSPECTED SPAM ***** " Dave Chinner
2013-07-19  6:45 ` [PATCH 25/49] libxfs: introduce xfs_trans_resv.c Dave Chinner
2013-08-05 20:16   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 26/49] libxfs: move transaction code to trans.c Dave Chinner
2013-08-05 20:51   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 27/49] xfs: move inode fork definitions to a new header file Dave Chinner
2013-08-05 21:39   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 28/49] xfs: move unrealted definitions out of xfs_inode.h Dave Chinner
2013-08-05 21:57   ` Mark Tinguely
2013-08-12  0:30     ` Dave Chinner [this message]
2013-07-19  6:45 ` [PATCH 29/49] xfs: introduce xfs_inode_buf.c for inode buffer operations Dave Chinner
2013-08-06 13:25   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 30/49] xfs: split out the remote symlink handling Dave Chinner
2013-07-19  6:45 ` [PATCH 31/49] libxfs: switch over to xfs_sb.c and remove xfs_mount.c Dave Chinner
2013-07-19  6:45 ` [PATCH 32/49] xfs: create xfs_bmap_util.[ch] Dave Chinner
2013-08-06 15:13   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 33/49] xfsprogs: sync minor kernel header differences Dave Chinner
2013-08-06 15:26   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 34/49] xfs: don't special case shared superblock mounts Dave Chinner
2013-08-06 15:33   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 35/49] xfs: move swap extent code to xfs_extent_ops Dave Chinner
2013-08-06 15:41   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 36/49] xfs: kill __KERNEL__ check for debug code in allocation code Dave Chinner
2013-08-06 15:52   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 37/49] xfs: remove __KERNEL__ from debug code Dave Chinner
2013-08-06 16:07   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 38/49] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c Dave Chinner
2013-08-06 16:12   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 39/49] xfs: move kernel specific type definitions to xfs.h Dave Chinner
2013-08-06 16:16   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 40/49] xfs: make struct xfs_perag kernel only Dave Chinner
2013-08-06 16:28   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 41/49] xfs: Introduce a new structure to hold transaction reservation items Dave Chinner
2013-08-06 18:23   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 42/49] xfs: Introduce tr_fsyncts to m_reservation Dave Chinner
2013-08-06 18:33   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 43/49] xfs: Make writeid transaction use tr_writeid Dave Chinner
2013-08-06 18:38   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 44/49] xfs: refactor xfs_trans_reserve() interface Dave Chinner
2013-08-06 19:12   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 45/49] xfs: Get rid of all XFS_XXX_LOG_RES() macro Dave Chinner
2013-08-06 19:23   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 46/49] xfs: Add xfs_log_rlimit.c Dave Chinner
2013-08-06 20:31   ` Mark Tinguely
2013-07-19  6:45 ` [PATCH 47/49] xfs: Add read-only support for dirent filetype field Dave Chinner
2013-08-06 21:13   ` Mark Tinguely
2013-08-12  0:33     ` ***** SUSPECTED SPAM ***** " Dave Chinner
2013-07-19  6:45 ` [PATCH 48/49] xfs: Add write " Dave Chinner
2013-07-19  6:45 ` [PATCH 49/49] xfsprogs: add dtype support to mkfs and db Dave Chinner
2013-07-21  6:34 ` [PATCH 00/49] xfsprogs: patches for crc-dev branch Michael L. Semon
2013-07-22 23:32   ` Dave Chinner
2013-07-23  3:36     ` Michael L. Semon
2013-07-23  4:44       ` Dave Chinner
2013-07-23 21:02         ` Michael L. Semon
2013-07-24  3:52           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812003039.GI12779@dastard \
    --to=david@fromorbit.com \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox