From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 87B177F37 for ; Sun, 11 Aug 2013 19:30:46 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 76C908F804B for ; Sun, 11 Aug 2013 17:30:43 -0700 (PDT) Received: from ipmail06.adl6.internode.on.net (ipmail06.adl6.internode.on.net [150.101.137.145]) by cuda.sgi.com with ESMTP id a75o1i2YNNNhOuEN for ; Sun, 11 Aug 2013 17:30:41 -0700 (PDT) Date: Mon, 12 Aug 2013 10:30:39 +1000 From: Dave Chinner Subject: ***** SUSPECTED SPAM ***** Re: [PATCH 28/49] xfs: move unrealted definitions out of xfs_inode.h Message-ID: <20130812003039.GI12779@dastard> References: <1374216324-8781-1-git-send-email-david@fromorbit.com> <1374216324-8781-29-git-send-email-david@fromorbit.com> <52001FB7.3010901@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52001FB7.3010901@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Mark Tinguely Cc: xfs@oss.sgi.com On Mon, Aug 05, 2013 at 04:57:11PM -0500, Mark Tinguely wrote: > On 07/19/13 01:45, Dave Chinner wrote: > >From: Dave Chinner > > > >Signed-off-by: Dave Chinner > >--- > > > >diff --git a/include/xfs_trans.h b/include/xfs_trans.h > >index e504103..37aca08 100644 > >--- a/include/xfs_trans.h > >+++ b/include/xfs_trans.h > >@@ -89,6 +89,13 @@ struct xfs_log_item_desc { > > #define XFS_ATTR_BTREE_REF 1 > > #define XFS_DQUOT_REF 1 > > > >+/* > >+ * Flags for xfs_trans_ichgtime(). > >+ */ > >+#define XFS_ICHGTIME_MOD 0x1 /* data fork modification timestamp */ > >+#define XFS_ICHGTIME_CHG 0x2 /* inode field change timestamp */ > >+#define XFS_ICHGTIME_CREATE 0x4 /* inode create timestamp */ > >+ > > in the kernel patch 13/49 these entries go into xfs_log_format.h Right, in the updated kernel series xfs_trans.h is no longer shared with userspace, and this patch series doesn't reflect that. it needs updating. > > #ifdef __KERNEL__ > > > > struct xfs_buf; > >diff --git a/libxfs/xfs.h b/libxfs/xfs.h > >index 7149c09..1a01c61 100644 > >--- a/libxfs/xfs.h > >+++ b/libxfs/xfs.h > >@@ -68,6 +68,9 @@ typedef __uint32_t inst_t; /* an instruction */ > > > > #define IHOLD(ip) ((void) 0) > > > >+#define XFS_IGET_CREATE 0x1 > >+#define XFS_IGET_UNTRUSTED 0x2 > >+ > > /* stop unused var warnings by assigning mp to itself */ > > #define XFS_CORRUPTION_ERROR(e,l,mp,m) do { \ > > (mp) = (mp); \ > > in the kernel patch 13/49 these entries go into xfs_icache.h Yup, they go into a kernel only header file. Userspace can define them how they want as xfs_iget() has different requirements and a completely different implementation in userspace. > > --Mark. > -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs