From: Dave Chinner <david@fromorbit.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: xfs@oss.sgi.com
Subject: Re: GRUB doesn't work on CRC enabled fs
Date: Tue, 13 Aug 2013 11:13:32 +1000 [thread overview]
Message-ID: <20130813011332.GU12779@dastard> (raw)
In-Reply-To: <20130812202924.GA354@x4>
On Mon, Aug 12, 2013 at 10:29:24PM +0200, Markus Trippelsdorf wrote:
> Just a heads-up: GRUB currently doesn't work on a CRC enabled
> file-system. It will print the following error message:
> "not a correct XFS inode"
Yup, that is expected. grub digs around in the on disk format, and
we changed it. So, grub won't work with v5 superblocks.
> GRUB's xfs implementation can be found here:
> http://bzr.savannah.gnu.org/lh/grub/trunk/grub/annotate/head:/grub-core/fs/xfs.c
if (grub_strncmp ((char *) inode->magic, "IN", 2))
return grub_error (GRUB_ERR_BAD_FS, "not a correct XFS inode");
So it's failing a magic number test. That means it's read the wrong
location for an inode, so it's getting something badly wrong. Almost
certainly it doesn't grok the new inode format and so isn't finding
the data fork of the inode correctly.
No surprise, really, it hard codes the location and size of the
inode literal area (to 156 bytes or 9 extents) and so will not parse
anything other than a 256 byte version 2 inode correctly. It doesn't
even realise that the literal area might contain an attribute
fork, or that inodes might be larger than 256 bytes.
This pretty much sums up why grub is fundamentally broken...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-08-13 1:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 20:29 GRUB doesn't work on CRC enabled fs Markus Trippelsdorf
2013-08-13 1:13 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813011332.GU12779@dastard \
--to=david@fromorbit.com \
--cc=markus@trippelsdorf.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox